Skip to content

Learned excuses: match bracket-style field names, count query names read during a check #1729

Closed

Description

@abrichr

Follow-ups from the round-3 independent review of #1679 (#1679 (comment)).

  1. Bracket-style names such as note[email] are recorded as-is and never matched to the email column, because _names splits only on .. This predates the PR for form bodies, and the new query-string code has the same gap. Split on brackets too, so a column the agent sends is never learned.
  2. record_bodies._check copies the query names before the check's own reads, so a GET that arrives during those reads isn't counted for that episode. The window is small (checks run after quiet_s of idleness), but the copy should be taken after the reads.

Activity

  1. added
    agent-readyReady for an automated agent to pick up
    claimedAn agent is working on this
    on Nov 4, 2026
  2. abrichr commented on Nov 4, 2026

    @abrichr
    MemberAuthor

    Claimed by Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyReady for an automated agent to pick upclaimedAn agent is working on this

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions