Repository navigation
feat(cli): syspi list prints the locked packages and whether each installed copy is present - #13
Open
devin-ai-integration[bot] wants to merge 5 commits into
Open
devin-ai-integration[bot] wants to merge 5 commits into
devin-ai-integration[bot] wants to merge 5 commits into
Conversation
…talled copy is present One line per lock entry in resource order: version, kind (the VCS of an exported tree), revision, path under lib/ and present/missing; standard libraries and local directories are listed as never installed. -json prints the same as an array. list reads only the lock and lib/. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: jason.han <hanhuijun@gmail.com>
Co-Authored-By: jason.han <hanhuijun@gmail.com>
…ad of calling it missing Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
There was a problem hiding this comment.
Devin Review found 1 finding. Devin automatically fixed it.
Fixed by Devin (1)
- Inaccessible packages falsely reported missing — List now returns the Lstat error unless it is not-exist, so an unreadable lib/ fails instead of listing copies as missing; tested with lib/ chmod 000.
…n stage Co-Authored-By: jason.han <hanhuijun@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syspi list [-C dir] [-offline] [-json]— the second of the commands 0.1.0 lacks. Independent of #10 (remove); both add the identical new fileinternal/install/libpath.go(libPath,installedMatchesmoved out of the resolver), so they merge in either order without a conflict.install.List(root)reads only.project.lock.jsonandlib/— no repository or server is contacted, so-offlinechanges nothing and is accepted for uniformity. Without a lock it fails (no .project.lock.json; run syspi lock or syspi install first); it writes nothing.Listingper lock entry in resource order (the lock's own order):resource,kind,publisher,name,version,vcs,tag,revision,source(archive URL/path or local directory),path(lib/<publisher>-<name>_<version>[.kpar], project-relative) andinstalled(present underlib/). Standard libraries and local directories have nopath/installed: recorded, never installed.text/tabwritertable —RESOURCE VERSION KIND REVISION PATH STATE,KINDbeing the VCS of an exported tree,STATEone ofpresent,missing,not installed:Presence is existence only; content against the lock is
verify's job (next PR).Tests:
internal/install/list_test.go(vcs, archive, local and standard entries; resource order; a removed copy ismissing, not an error) andtests/e2e/list_test.go(text and-jsonoutput, determinism, nothing written, the git/hg/svn fixtures). Docs: README "Commands",docs/packages.md"Install layout",changes/unreleased/list.added.md.Link to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/888897f71c264c89a8abc11e9a432241
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/888897f71c264c89a8abc11e9a432241?variant=devin
Requested by: @HuiJun
🟢 Devin Review found nothing to fix · View findings · Follow Devin's work