Repository navigation
fix(smt): spell a divergence's values in the check engine's order whichever copy the solver gave which - #2168
Queued
devin-ai-integration[bot] wants to merge 2 commits into
Queued
devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…chever copy the solver gave which z3 4.13 answers the two-copy sensitivity query with the copies the other way round from 4.8, so the report, the witness pair and the test depended on the solver; the pair is now ordered as runtime's Divergence is. The optimizer's open-bound test asserts the semantics (no optimum, no value standing for it) and accepts either a named bound or an unestablished optimum. Co-Authored-By: jason.han <hanhuijun@gmail.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Co-Authored-By: jason.han <hanhuijun@gmail.com>
5 of 6 tasks
devin-ai-integration
Bot
added this pull request to the merge queue
Nov 12, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Two
internal/frontend/repltests failed onubuntu-latest= ubuntu-26.04, whose apt z3 is 4.13.3 (24.04: 4.8.12):TestEngineSMTDecidesSensitivity: the two-copy sensitivity query's model came back with the copies the other way round, so the report readx ends as 2 or 1and witness A/B swapped. The check engine spells a divergence's values in string order (runtime.Divergence);Encoding.Divergingnow orders the pair the same way, whichever copy the solver gave which value, so the report and the witness files no longer depend on the solver's model order.TestOptimizeReportsABoundThatIsNotAttained: z3 4.13 names the open bound (the REPL already reports it as "no greatest value, approaching 10.5 without attaining it"), 4.8 does not ("no optimum reported"). The test now asserts the semantics — status no-optimum, the header, no value standing for the optimum — and accepts either answer.Follow-up to the ubuntu-24.04 pin (#2165); with this the solver packages are green on either image.
How it was verified
OPENSYSML_REQUIRE_SMT=1 OPENSYSML_SMT=<z3> go test -count=1 ./internal/exec/smt ./internal/frontend/repl ./internal/exec/solvegreen under both z3 4.8.12 (apt) and 4.13.3 (pip install z3-solver==4.13.3.0); ondevelopunder 4.13.3 the two tests fail as in CI.gofmt -l .,go vetclean;python3 scripts/changelog.py check.Checklist
make testandmake lintpass locally (the solver packages above; CI runs the rest)changes/unreleased/<slug>.<section>.md, not as an edit toCHANGELOG.mdmake docs-countsrun if a gate count moved (none moved)F4,K5) in the body, docs, or changelogLink to Devin session: https://nasa-jpl-demo.devinenterprise.com/sessions/a8e2a2c0d31143598a07d32facbf02fa
Open in Devin Desktop: https://nasa-jpl-demo.devinenterprise.com/desktop/session/a8e2a2c0d31143598a07d32facbf02fa?variant=devin
Requested by: @HuiJun
🟢 Devin Review found nothing to fix · View findings