Repository navigation
STACAPIJobDatabase: faster counting, paging and existence check (#972) - #973
Open
omaraldulimay wants to merge 2 commits into
Open
omaraldulimay wants to merge 2 commits into
omaraldulimay wants to merge 2 commits into
Conversation
…-EO#972) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…versions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #972
Changes to
STACAPIJobDatabaseandMultiBackendJobManager:count_by_status()now uses thenumberMatchedvalue of the search response instead of fetching all items, with a fallback to the old behavior when the back-end does not provide it.search_page_size) instead of the server default (often 10), so far fewer requests are needed when paging through items.exists()does a directget_collectionlookup instead of listing collections.MultiBackendJobManageris only built when INFO logging is enabled, which avoids a needlesscount_by_status()call.Tests:
tests/extra/job_management/test_stac_job_db.py, including thenumberMatchedfallback.tests/extra/job_management/: 192 passed.tests/extra/artifacts, which errors in this environment on a moto/AWS bucket location setting, unrelated to this change.This PR was drafted with the help of Claude Code.