Skip to content

RPC DiscoverLayers: consider layers from all packs#2534

Merged
brondani merged 1 commit into
mainfrom
rpc-discoverlayers-consider-layers
Jul 24, 2026
Merged

RPC DiscoverLayers: consider layers from all packs#2534
brondani merged 1 commit into
mainfrom
rpc-discoverlayers-consider-layers

Conversation

@brondani

@brondani brondani commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes

Changes

  • Ensures DiscoverLayers considers compatible layers from packs not selected by the solution.
  • Temporarily use the ALL pack-loading policy while listing compatible layers, then restore the default policy.
  • Add a solution fixture and RPC regression test covering discovery across all installed packs.

Checklist

  • 🤖 This change is covered by unit tests (if applicable).
  • 🤹 Manual testing is not necessary.
  • 🛡️ Security impacts have been considered; no direct impact identified.
  • 📖 Documentation updates are not required.
  • 🧠 Third-party dependencies and TPIP updates are not required.

@brondani
brondani requested a review from Copilot July 24, 2026 13:15
@brondani brondani changed the title RPC DiscoverLayers: consider layers from all packs RPC DiscoverLayers: consider layers from all packs Jul 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ProjMgr RPC DiscoverLayers implementation so it can discover compatible layers from packs beyond those explicitly selected by the solution, addressing Open-CMSIS-Pack/vscode-cmsis-solution#351.

Changes:

  • Switch DiscoverLayers to temporarily use LoadPacksPolicy::ALL while enumerating compatible layers, then restore the prior behavior afterward.
  • Add a new .csolution.yml fixture that selects an older pack version to validate discovery still finds layers from other installed packs.
  • Add an RPC regression test to cover discovery across all installed packs.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tools/projmgr/src/ProjMgrRpcServer.cpp Temporarily sets pack-loading policy to ALL during layer discovery.
tools/projmgr/test/src/ProjMgrRpcTests.cpp Adds regression test for discovering layers across all installed packs.
tools/projmgr/test/data/TestLayers/config-discover-all-packs.csolution.yml New fixture selecting a specific older pack version to validate cross-pack discovery.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/projmgr/src/ProjMgrRpcServer.cpp
@github-actions

Copy link
Copy Markdown

Test Results

  2 files   14 suites   14m 46s ⏱️
476 tests 476 ✅ 0 💤 0 ❌
952 runs  952 ✅ 0 💤 0 ❌

Results for commit ac85040.

@brondani
brondani marked this pull request as ready for review July 24, 2026 13:32
@brondani
brondani requested a review from edriouk July 24, 2026 13:32
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 65.36%. Comparing base (a7fcd69) to head (ac85040).

Files with missing lines Patch % Lines
tools/projmgr/src/ProjMgrRpcServer.cpp 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2534   +/-   ##
=======================================
  Coverage   65.36%   65.36%           
=======================================
  Files         147      147           
  Lines       26800    26803    +3     
  Branches    16237    16240    +3     
=======================================
+ Hits        17518    17521    +3     
  Misses       7075     7075           
  Partials     2207     2207           
Flag Coverage Δ
projmgr-cov 87.97% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tools/projmgr/src/ProjMgrRpcServer.cpp 85.83% <75.00%> (+0.06%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@edriouk edriouk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brondani
brondani merged commit b0c5f28 into main Jul 24, 2026
31 checks passed
@brondani
brondani deleted the rpc-discoverlayers-consider-layers branch July 24, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants