RPC DiscoverLayers: consider layers from all packs#2534
Conversation
DiscoverLayers: consider layers from all packs
There was a problem hiding this comment.
Pull request overview
This PR updates the ProjMgr RPC DiscoverLayers implementation so it can discover compatible layers from packs beyond those explicitly selected by the solution, addressing Open-CMSIS-Pack/vscode-cmsis-solution#351.
Changes:
- Switch
DiscoverLayersto temporarily useLoadPacksPolicy::ALLwhile enumerating compatible layers, then restore the prior behavior afterward. - Add a new
.csolution.ymlfixture that selects an older pack version to validate discovery still finds layers from other installed packs. - Add an RPC regression test to cover discovery across all installed packs.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/projmgr/src/ProjMgrRpcServer.cpp | Temporarily sets pack-loading policy to ALL during layer discovery. |
| tools/projmgr/test/src/ProjMgrRpcTests.cpp | Adds regression test for discovering layers across all installed packs. |
| tools/projmgr/test/data/TestLayers/config-discover-all-packs.csolution.yml | New fixture selecting a specific older pack version to validate cross-pack discovery. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 2 files 14 suites 14m 46s ⏱️ Results for commit ac85040. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2534 +/- ##
=======================================
Coverage 65.36% 65.36%
=======================================
Files 147 147
Lines 26800 26803 +3
Branches 16237 16240 +3
=======================================
+ Hits 17518 17521 +3
Misses 7075 7075
Partials 2207 2207
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Fixes
DiscoverLayersshould consider all loaded packs and add newly required pack reference tocsolution.ymlvscode-cmsis-solution#351Changes
DiscoverLayersconsiders compatible layers from packs not selected by the solution.ALLpack-loading policy while listing compatible layers, then restore the default policy.Checklist