Skip to content

[A11y Bug 12069078] Fix visibility of toggle highlighter button in dessert theme - #673

Merged
Aanchal Bhansali (aanchalbhansali) merged 4 commits into
masterfrom
copilot/toggle-highlighter-mode-issue
Sep 22, 2026
Merged

Aanchal Bhansali (aanchalbhansali) merged 4 commits into
masterfrom
copilot/toggle-highlighter-mode-issue

Conversation

Copilot AI commented Sep 20, 2026

Copy link
Copy Markdown
Contributor
  • Inspect highlighter states, forced-colors styling, and available validation.
  • Fix highlighter icon contrast without changing normal-theme behavior.
  • Validate build/lint and browser rendering in inactive, active, and focused states.
  • Scan changes for secrets and complete automated review.
Original prompt

[OneNote Clipper] [Web] [Dessert Theme]: "Toggle Highlighter Mode for Article" button is not visible when activated.

Work Item Details

Note: Please focus on the descriptions and information that provide context about the task requirements, functionality, and implementation details. Dates, priorities, and administrative metadata are less relevant for coding tasks.

Description

"Please do not close this bug. This bug should only be closed by TCS, E+D Accessibility tester after verification of the fix."

Environment Details:

Application Name: OneNote Clipper-web

Platform: Web

OS Version: Windows 11 25H2(26220.8764)

Edge Version: Version 150.0.4078.65 (Official build) (64-bit)

Theme: Dessert Theme

Repro Steps:

  1. Launch OneNote Web Clipper.
  2. Sign in with a valid account.
  3. Navigate to the Article button on the right side panel and activate it.
  4. Apply the Dessert Theme.
  5. Activate the "Toggle Highlighter Mode for Article" button located in the toolbar on the left side of the article content area.
  6. Observe the visibility of the activated button.

Actual Result:

When the Toggle Highlighter Mode for Article button is activated in Dessert Theme, the button is not visible or becomes difficult to perceive due to insufficient visual differentiation between the button state and the background.

Expected Result:

The Toggle Highlighter Mode for Article button should remain clearly visible and distinguishable in both default and activated states. Sufficient contrast and visual indicators should be provided so that users can easily identify the button and its current state.

User Impact:

Users with low vision or users relying on visual cues may be unable to identify the presence or state of the button when it is activated, making it difficult to understand or use the highlighter functionality.

MAS Reference:

MAS 1.4.11 – Non-text Contrast

"If the bug is invalid, incomplete, wrong severity, has unclear reproduction steps or attachments, please tag it with "A11yRCA" and provide a detailed comment on why the A11yRCA tag was added. However, do not add the "A11yRCA" tag if the bug is related to partners or if you have any questions about the bug."

Tags

A11yMAS; A11yONTriaged; A11yRT; A11ySev2; Accessibility; Freeway-Bug; FY27; MAS1.4.11; OneNoteClipper_Web; RT-July2026; TCS-E+D; Web

RCA Analysis

Was change validated in devMain first before porting to fork?

Why was Flighting|Backout not used?

Impact of bug (# users affected):

RCA and Mitigation/Fix Details:

What are you doing to prevent this in the future?

Work item: AB#12069078
Created via Azure DevOps

Copilot AI and others added 2 commits September 20, 2026 15:28
Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
Agent-Logs-Url: https://github.com/OneNoteDev/WebClipper/sessions/55e1525b-a704-48d5-a04b-f9c144e5a476

Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>
@aanchalbhansali

Copy link
Copy Markdown
Contributor

Copilot Why are the changes in package-lock.json file needed?

Co-authored-by: aanchalbhansali <185747873+aanchalbhansali@users.noreply.github.com>

Copilot AI commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Copilot Why are the changes in package-lock.json file needed?

They weren’t needed. An npm install during setup rewrote eight peer metadata entries without changing dependencies. I restored package-lock.json in d2e19ee, so the PR now only changes src/styles/renderer.less.

@aanchalbhansali Aanchal Bhansali (aanchalbhansali) changed the title [WIP] Fix visibility of toggle highlighter button in dessert theme [A11y Bug 12069078] Fix visibility of toggle highlighter button in dessert theme Sep 21, 2026
@aanchalbhansali
Aanchal Bhansali (aanchalbhansali) marked this pull request as ready for review September 21, 2026 10:36

@dewanymca dewanymca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aanchalbhansali
Aanchal Bhansali (aanchalbhansali) merged commit 2bab8b2 into master Sep 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants