Skip to content

fix(phase): improve finish callback handling and allow multiple callbacks - #99

Merged
theEvilReaper merged 3 commits into
mainfrom
fix/phaseCallback
Oct 9, 2026
Merged

theEvilReaper merged 3 commits into
mainfrom
fix/phaseCallback

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

Currently the phaseseries implementation overwrites the handling of the finishCallback. The pull request fixes that and allows the usage of multiple callbacks at the end of an phase.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Test results

 78 files   78 suites   25s ⏱️
109 tests 109 ✅ 0 💤 0 ❌
327 runs  327 ✅ 0 💤 0 ❌

Results for commit 9a9b33b.

@theEvilReaper
theEvilReaper merged commit 5e08c25 into main Oct 9, 2026
8 checks passed
@theEvilReaper
theEvilReaper deleted the fix/phaseCallback branch October 9, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant