Repository navigation
fix(team): fix capacity check and Splitter distribution - #101
Merged
Merged
Conversation
Contributor
Test results 81 files 81 suites 22s ⏱️ Results for commit 113223c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes two bugs in the team module. Team#canJoin used to check size != capacity, so a team above its capacity still let players join, for example after lowering the capacity with setCapacity. It now uses <, so a team at or above its capacity rejects new players. Splitter#compute returned null when an even brute-force distribution was impossible, which caused an NPE in DefaultTeamDistributor, and it now throws an IllegalArgumentException with a clear message instead. The low-variance (greedy) mode is unchanged and still exceeds the team size when there are too many players, as the existing tests expect.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.