Skip to content

fix(phase): fix GamePhase, TimedPhase and LinearPhaseSeries bugs - #100

Merged
theEvilReaper merged 4 commits into
mainfrom
fix/phaseBugs
Oct 9, 2026
Merged

theEvilReaper merged 4 commits into
mainfrom
fix/phaseBugs

Conversation

@theEvilReaper

@theEvilReaper theEvilReaper commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

The pull request addresses the following issues:

  • GamePhase#removeListener now removes the listener that is actually registered, and returns null instead of throwing an NPE for unknown event classes
  • Calling GamePhase#start on a phase that is already running no longer fails with "Node already has a parent"
  • TimedPhase#onFinish is only invoked once, even if finish() is called multiple times
  • Resuming a paused LinearPhaseSeries no longer skips the running phase, and pausing before the series has started no longer throws

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper self-assigned this Oct 9, 2026
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Test results

 81 files   81 suites   17s ⏱️
116 tests 116 ✅ 0 💤 0 ❌
348 runs  348 ✅ 0 💤 0 ❌

Results for commit c71e73e.

@theEvilReaper
theEvilReaper merged commit 8d757d7 into main Oct 9, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant