Skip to content

fix: stop iOS popover sheets opening scrolled away inside the collapsible pager and limit the activity description action to its text - #261

Merged
weatherstar merged 10 commits into
mainfrom
fix/description-touch-and-overlay-scroller-ok-67219-ok-67220
Nov 13, 2026
Merged

weatherstar merged 10 commits into
mainfrom
fix/description-touch-and-overlay-scroller-ok-67219-ok-67220

Conversation

@weatherstar

@weatherstar weatherstar commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Problem

Two reports against the Home History list in App-6.7.0:

  1. iOS: the contract label sheet opens with an empty body. Tapping the contract label under a history row title opens a sheet with the label as its title, but the address below it is missing until the sheet is dragged. It only happens once the list has been scrolled far enough for the Home header to collapse.
  2. iOS and Android: the contract label takes taps on the whole line. Tapping the blank area to the right of the label opens the label sheet instead of the transaction details. On desktop only the label text is clickable.

Root cause

  1. react-native-pager-view (iOS). A native Popover keeps its content mounted inside the NativeOverlay host view until the overlay window presents it, and the host sits where the Popover element is, so inside the pager page. resolveScrollCandidateInView: ranks a Fabric scroll view (tier 3) above a verified NativeList (tier 2), so the staged sheet RCTScrollViewComponentView became the page's scroll owner and received the collapsed-header offset. A view hierarchy dump taken while the body was empty shows the sheet scroll view at contentOffset {0, 268} with contentSize {335, 60.5}: the content is scrolled out of view, and a drag lets UIKit bounce it back. With the header expanded the applied offset is 0, which is why the list has to be scrolled first.
  2. react-native-native-list (iOS and Android). The Activity description label spans the identity column, and the action was bound to the whole label (UITapGestureRecognizer on the label, setOnClickListener on the TextView). The Web renderer bound the action to an element it cut out of the description at the first •.

Fix

Pager (iOS)

RNCCollapsiblePagerViewComponentView.mm: the four scroll lookups (resolveScrollCandidateInView:, findExplicitNativeScrollerInView:, findFabricScrollViewInView:, findVerticalScrollViewInView:) skip RCTNativeOverlayComponentView subtrees. The class is looked up by name, so nothing changes when the overlay package is absent, and a scroll view outside a host keeps its priority. docs/SPEC.md records the overlay host as a discovery boundary.

Description action (iOS, Android, Web)

New field ActivityRow.descriptionActionStart. The caller that assembles the description states where its action text starts; no renderer reads that out of the displayed string any more. This removes the • inference from Web, where it already was, and from iOS and Android, where the first version of this PR had copied it.

  • A UTF-16 offset into description as supplied (a JavaScript string index). The text from the offset on opens descriptionActionKey; the text before it is plain and belongs to the row press.
  • Absent means 0: the whole description text is the action. description.length leaves no action text; the row then has no description action and no button semantics on any platform. The field is ignored without descriptionActionKey.
  • Validation: development rejects a value that is not a non-negative safe integer, and on a complete row (a snapshot row, or a row after a patch is merged) a value past description.length. Production drops a malformed value, which restores the default, and the renderers clamp a value past the text to its end.
  • Patches: descriptionActionStart is a patch field. A patch that changes description without restating the offset clears the stored one, because it pointed into the previous string.
  • descriptionActionKey keeps its meaning. There is no rich text, no second action and no segment list.

Renderers.

  • Web (ActivityRowRenderer.ts): the description is a plain prefix element and the action button, split at the offset. The time, dot and address elements are gone. Measured in Chrome, the button of 08:48 • Router • V2 starts 0.4px further left than before (two spaces instead of two 4px margins); truncation still ends in an ellipsis.
  • Web truncation: a prefix that fits keeps its width and the action truncates first, as before and as the tail of the native label does. While action text follows, the prefix is capped at the row width less 3em and truncates itself, so a prefix wider than the row no longer squeezes the action button to zero width. iOS and Android draw one label and do not reserve room.
  • iOS (NativeListTextLabel.swift) and Android (NativeListTextView.kt): one optional touchableTextStart replaces the touchesTextOnly switch and its start. No value keeps the view's own hit testing (rows without the action), 0 limits touches to all of the text, a positive value to the text from there on. Binding, rebinding without the action and recycling set or clear that one value.
  • The hit area follows the laid-out text. It is built from the layout engine's own rects for the action's character range (TextKit enclosing rects on iOS, the layout's selection on Android), one per line and per visual run. A suffix that mixed-direction text splits into several runs, as in ABC אבג XYZ from offset 6, is hit on each run and not on the plain text between them.
  • Touch slop reaches into blank space only. Each run is widened by 8 units, and the widening stops at plain text on the same line: with iRouter and start 1 the i, which is narrower than the slop, no longer opens the action. On iOS the 6pt vertical slop applies to the first and last line of the whole layout only. Before, it was applied after the lines without action text had been dropped, so with the time alone on the first line the address line reached 6pt up into it.
  • An ellipsis belongs to the action while action text is visible before it. Once truncation hides the action text altogether, nothing is left to touch.
  • Android reads the offset as a Long and clamps it before narrowing. With optInt, a safe integer past Int range such as 4294967296 came back as 0 and made the whole text the action.
  • iOS and Android map the offset onto the displayed text: a one-line description folds each line break into one space, which moves the offsets after a CRLF.

docs/SPEC.md and docs/ROW_TEMPLATES.md describe the field, its default, validation, the patch rule and the hit area.

Callers

The only callers of descriptionActionKey are in app-monorepo (the Home history list and a gallery fixture). They pass descriptionActionStart in the dependency upgrade that follows this release; that change is prepared and was used for the runtime checks below. Until a caller passes the field, the whole description text is the action.

Validation

  • JavaScript: yarn jest in react-native-native-list, 529 tests pass; yarn typecheck is clean. New cases cover the accepted range, rejected values, the production fallback, the patch rule, and the Web DOM for Router • V2, 08:48 • Router • V2, an emoji prefix, a start at the end, a row without the action and a prefix wider than the row.
  • Web layout, Chrome: jsdom has no layout, so the same CSS was measured in Chrome. In a 160px row with a 308px prefix the action button was 0px wide before the cap; with it the prefix takes 118px and Router 42px, V2 its full 18px. 08:48 • with a long label in a 243px row is unchanged: prefix 52.7px, label 190.3px with an ellipsis.
  • Android, JVM: NativeListDescriptionTouchPolicyTest, 7 tests pass (run through the app-monorepo Android project with these sources), including the slop stopping at a 3px prefix, two runs with plain text between them, and offsets past Int range.
  • Android, real touch dispatch: native-tests/android/NativeListDescriptionActionTouchTest.kt binds rich Activity rows in a NativeListView and taps the description line with sendPointerSync, so the events travel window → RecyclerView → row. On an arm64 emulator (API 36): OK (7 tests). With iRouter and start 1, a tap on the i emits the row press and a tap on the R the description action. With ABC אבג XYZ and start 6, taps on ABC and on the two plain Hebrew letters emit the row press, taps on the last Hebrew letter and on XYZ the action; the tap positions come from Paint.measureText, not from the regions under test. The existing NativeListTouchDeliveryTest (4) and NativeListRiskAccessoryTest (23) also pass with these sources. The test APK was built through the app-monorepo Android project with an init script equivalent to reorder-test.init.gradle; the example project's Gradle build does not complete on my machine. Not run inside the OneKey app on Android.
  • iOS, label level: NativeListTextLabel.swift from this branch was compiled into a simulator binary and run on iOS 26.5. iRouter from 1: the region starts at 3.3pt, the width of the i, and still reaches 8pt past the end of the text. ABC אבג XYZ from 6: two regions, 32.0–37.7 and 54.9–94.1, with the two plain letters between them. With the time alone on the first line the address region starts at the line boundary (y = 20). A truncated label is touchable up to its ellipsis; a prefix that pushes the action out of view leaves no region. These are the values the XCTest cases assert.
  • iOS XCTest suites run only in the native-tests workflow of this PR (I did not set up the iOS test workspace locally).
  • iOS, runtime: the sources of f702219 and the prepared caller change were built into the OneKey app (app-monorepo DevSession, --shell local) and exercised on an iPhone SE (3rd generation) simulator, iOS 26.5.
    • With a debug-only time prefix and label (17:29 • Router • V2, start 8), six taps along the description line: the time and the separator right before the label (6pt left of the label, inside the former slop) open the transaction details; the start of the label and V2 open the sheet; the blank 5pt after the text, inside the slop, opens the sheet; the blank 35pt after the text opens the transaction details.
    • On the earlier build of this branch: phone rows that carry the label only (descriptionActionStart: 0) open the sheet on the label and the transaction details on the blank beside it, and a label Router • V2 without a time opens the sheet on both of its words.
    • This list truncates the description to one line, so a wrapped description was not exercised at runtime, and neither was mixed-direction text.
    • Pager: checked on the first build of this branch, and that code has not changed since. With the Home header collapsed, the label sheet showed an empty body before the change and the address from the first frame after it.
  • Android pager owner discovery was not inspected; the empty-body symptom was only reported and reproduced on iOS.

Release note

Merging publishes the next stable revision. The app picks the fixes up with the following dependency upgrade in app-monorepo, which also has to pass descriptionActionStart from the Home history list.

… lookup

Overlay content (popover, sheet, dialog) stays mounted inside its host view until the overlay window presents it, and the host can sit in a page's subtree. A Fabric scroll view outranks a verified native list in the candidate tiers, so the collapsible pager adopted the staged sheet scroller as the page owner and applied the collapsed-header offset to it. The sheet then opened scrolled past its content until a drag bounced it back.

Every scroll view lookup now skips overlay host subtrees.
The description label spans the identity column and took the action for a tap anywhere on its line, so tapping the blank area beside a contract label opened the label instead of the row.

iOS and Android now take touches on the drawn text only (plus a small slop), and of a "time • address" description only on the address, as the Web renderer does. Other touches fall through to the row press.
@weatherstar
weatherstar enabled auto-merge (squash) November 13, 2026 03:19
… on wrapped rows

The touch area excluded the leading time only on a single-line description; once "time • address" wrapped, the whole text took the action again, on iOS and Android.

The touchable area is now computed per laid-out line: a line before the address takes no touches, the line that holds the separator takes them from the address on, and later lines take them on their text. The vertical slop only grows away from the text, so it cannot reach into the time's line.
…the row's column split

The row-level cases assumed the identity column keeps most of a 366pt row. With a short amount the amounts column takes its full half, the label is about 119pt wide, and the blank area beside "08:48 • Uniswap" is narrower than the touch slop, so the right-edge assertions failed on the test geometry, not on the hit area.

The row-level cases now use a row wide enough to leave blank space in any split and assert it, and the wrapped case sizes the label directly.
@huhuanming

huhuanming commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

请按以下审计要求修改后再合入。审计基于当前 head e6aff7bbceaa5025b5ffcf1f7795d86796977124。

原生与业务层边界:避免阻断业务 OTA

通用原生组件只负责明确契约下的渲染、布局和交互,不应通过业务文案、分隔符、具体动作名或其他隐含格式推断业务行为。业务语义及其格式应由业务层决定,并通过显式、可校验且可扩展的数据契约传入。

原生代码的修改需要重新构建并随 App 发版,不能靠 JS OTA 替换已安装的原生实现。把业务规则写死在原生层,会让原本可通过 JS OTA 完成的标签、文案或格式调整依赖原生升级,阻断对应业务变更的 OTA 交付。因此本 PR 及后续原生改动都应将这类严重业务耦合作为 review 阻断项;字段设计要允许业务变化在既有原生能力内完成,避免每次业务格式变化都修改原生代码。

这里要求移除的是对业务语义的隐式推断;明确声明的模板字段、组件生命周期和滚动所有权等技术契约可以保留。

[P0] 移除通过显示分隔符推断点击范围的业务格式耦合

位置:

  • native-views/react-native-native-list/ios/NativeListActivityDetailsView.swift:203–205
  • native-views/react-native-native-list/android/src/main/java/com/onekey/nativelist/NativeListModels.kt:70–72
  • 同步检查 Web 的 src/web/templates/ActivityRowRenderer.ts:582–594。

当前实现将描述中第一个 • 前的内容一律视为不可点击的时间。这个显示字符串不能可靠表达业务语义:调用方可以把自由标签原样作为整段描述,例如没有时间前缀的 Router • V2,此时 Router 同样应可点击,却会被排除。Web 原来已有该假设,本 PR 将它扩散到了 iOS/Android。

这是本次审计的 P0 合入阻断项:通用 NativeList 不应通过显示文案猜测哪部分是时间、地址或标签。

要求修改:

  • 由组装描述的调用方显式提供动作起点,例如可选的 descriptionActionStart;使用最终描述字符串的 UTF-16 偏移,0 表示全部文字,正数表示从该位置开始的后缀。
  • iOS、Android、Web 统一消费这一契约;明确缺省值、整数校验和 0..description.length 边界,末尾起点对应空热区。
  • 已知调用方应在组装描述时记录真实边界,不再让渲染层依据 • 反推。不要保留分隔符推断作为常规判断路径。
  • 同步类型、输入/patch 校验、SPEC 和相关调用方,保持现有 descriptionActionKey 的动作语义。
  • 当前仅有单个可点击后缀的需求,无需为此加入富文本、多动作、segments[] 或通用注册框架。

[P1] 修正 iOS 首行纯时间时,下一行地址热区向上侵入的问题

位置:native-views/react-native-native-list/ios/NativeListTextLabel.swift:38–56。

当前先过滤掉纯时间行,再对剩余数组的第一行向上扩 6pt。如果物理首行只有 08:48 • 、地址从第二行开始,地址热区会向上侵入时间行下缘,与“不会进入相邻行”的注释和时间不可点击的契约冲突。

**要求修改:**按完整布局中的物理首/末行确定垂直容差,或将扩展限制在不会覆盖相邻物理行的范围。补一条首行纯时间、地址从第二行开始的测试,断言分界线上方约 2pt 的时间区域不会触发地址动作。

此项来自源码几何分析,尚未实机复现。当前 Home 显式单行不受这个换行边界影响,但通用 Activity 默认两行,且这是本 PR 已承诺支持的行为。

收敛内部属性,避免重复可变状态

将 touchesTextOnly 和 touchableTextStart 收成一个可空起点即可:

  • nil / null:原控件命中行为。
  • 0:仅全部文字的热区。
  • 正数:仅指定起点之后的文字热区。

绑定、无动作重绑和 recycle 都应统一设置或清空这一状态,避免开关与起点不同步。这个内部默认行为应与上面的公共字段缺省语义分别写清楚。

保留的设计边界

  1. **保留 Pager 的 Overlay 子树隔离。**它符合原生视图所有权,动态查类避免对 Overlay 包的强依赖。四个现有查找方法保持同一边界即可,无需新增协议、注册表或配置项;也无需为了本次修复重构这些查找方法。
  2. **保留逐行文字热区计算。**原 review 的换行意见有依据,Activity 本来就支持换行;目前通常换行情形已经修复,无需推翻已完成的逐行方案,只需补齐上面的物理行边界。

聚焦验收

  • 没有时间的 Router • V2 整个标签可点。
  • 08:48 • Router • V2 仅时间前缀不可点,完整标签可点。
  • 首行只有时间、次行为地址时,时间行下缘仍不可触发地址动作。
  • 动作移除、重绑和 recycle 后状态正确;补充非 ASCII / emoji 前缀的 UTF-16 偏移验证。
  • 标签点击触发面板,文字外空白交给行进入交易详情;Android 需验证实际触摸分发,JVM 几何测试不能替代这项验收。

The first " • " of the description decided which part of it opens
descriptionActionKey: on Web before, and on iOS and Android since this
branch. A label is free text, so "Router • V2" lost its first word, and
any change of the description format needed a native release.

ActivityRow.descriptionActionStart is the UTF-16 offset the action text
starts at; absent means the whole text. Web, iOS and Android consume it
and no renderer parses the string. Validation checks the type and, on a
complete row, the range; production drops a malformed value and the
renderers clamp. A patch that changes the description without restating
the offset clears it.

The native text views hold one optional start in place of a switch and
a start, so the two cannot disagree.
…ove on iOS

The vertical slop was added after the lines without action text had
been dropped. With the time alone on the first line, the address line
became the first touchable line and reached 6pt up into the time, which
is not part of the action.

The slop now belongs to the first and last line of the whole layout, so
it never reaches into another line, touchable or not.
…spatch on Android

The JVM test covers the geometry only. This instrumented case binds rich
Activity rows in a NativeListView and taps the description line with
sendPointerSync: the text from descriptionActionStart on emits the
description action, the text before it and the blank width emit the row
press. It also covers an emoji prefix, a start at or past the end, and
rebinding, removing the action and recycling.
@weatherstar

Copy link
Copy Markdown
Contributor Author

审计各项已修改,head b72dc484,PR 描述已同步更新。

  • P0:新增 ActivityRow.descriptionActionStart(description 的 UTF-16 偏移,缺省 0 为全部文字,末尾起点为空热区)。iOS、Android、Web 统一消费,三处 • 推断都已删除。类型、快照与 patch 校验、SPEC 已同步,descriptionActionKey 语义不变。
  • P1:iOS 垂直容差按完整布局的物理首末行判定,补了首行纯时间的测试。
  • 属性收敛:两端合成一个可空的 touchableTextStart。
  • 保留项:Pager 隔离和逐行热区未改动。

需要说明的几点:

  1. 调用方还没落地。 本仓库内没有调用方;app-monorepo 的两处改动已写好并验证,但依赖本 PR 发布后的类型,会和发版后的依赖升级放在同一个提交里。
  2. 验证范围。 Android 用新增的仪器测试验证了实际触摸分发(sendPointerSync,API 36 模拟器,OK (5 tests)),没有在 OneKey App 内整体跑。iOS 在 App 内实测通过;XCTest 本轮 CI 还在跑。
  3. 超出审计原文的处理:换行折叠后的偏移映射、生产态丢弃非法值并收边(不拒绝整行)、patch 改描述时清除旧偏移、起点在末尾时不绑定动作。不需要的话我删掉。
  4. 水平容差会向起点左侧延伸 8pt,落在前缀末尾(对 08:48 • 标签 是分隔符)。按「只需补齐物理行边界」没有改;如需前缀完全不可点,起点一侧去掉容差即可。

…ong prefix

The prefix element did not shrink and could take the whole line, so a
prefix wider than the row squeezed a non-empty action button to zero
width and left it without a pointer target.

While action text follows, the prefix is capped at the row width less
3em and truncates itself. A prefix that fits keeps its width and the
action still truncates first, as the tail of the native label does.
@originalix

Copy link
Copy Markdown
Contributor

要带到 6.7 的话,更新一下版本号

@huhuanming

Copy link
Copy Markdown
Contributor

复审基于最新 head 630c179849416e1da75f722f8542ce02637dbd0a,已完成主审和 astra high 独立交叉核对。

原 P0 业务耦合已修复,原 P1 垂直上侵已修复;目前仍有一项 P1,修正后再合入。

已确认:

  • iOS、Android、Web 均直接消费 descriptionActionStart,三处分隔符推断已删除,Router • V2 不再被错误拆分。显式 UTF-16 起点的契约满足当前单个后缀动作需求,不需要再引入通用富文本框架。
  • 两端内部状态已合并成可空 touchableTextStart,绑定、无动作重绑和 recycle 的清理路径完整。
  • iOS 垂直余量按物理首末行计算,首行纯时间的回归测试已在本轮 hosted XCTest 中通过。
  • Pager 的 Overlay 子树隔离保留,无新增业务语义耦合。

仍需修改:[P1] [🔵 High] 水平热区越过显式动作范围。

已发 inline:#261 (comment) 。

合法短前缀 iRouter、start=1 时,8pt 余量会覆盖普通前缀字符 i,因此不能把目前的水平扩展直接视为满足“前缀属于行点击”的契约。请保留朝空白区域扩展的触控余量,限制其侵入普通文字。

此外,动作的逻辑后缀在混合方向排版中可能不是一个连续矩形,例如 ABC אבג XYZ、start=6 的后缀是 ג XYZ,其可点视觉片段之间夹着不可点前缀字符。实现应使用实际排版的动作选区或触点对应的字符范围,避免仅依赖每行一个包围矩形。混合排版部分尚未做手机复现,短前缀问题由源码公式即可确定。

另有 [P2] [🔵 High] Android 超长偏移的整数窄化。

NativeListActivityDetailsView.kt:110 用 optInt 读取偏移。生产验证允许非负 safe integer,4294967296 会保留;JSON 将它读成 Long 后,optInt 得到 0,导致整段可点,违反“超长偏移收至末尾”的约定。已在本地主机 JSON 实现复现该窄化;正常 prefix.length 不会产生该值,因此列为 P2,不作为当前合入阻断项。建议读取 Long,按源字符串长度 clamp 后再转 Int。

对新增处理的结论:建议保留。

换行折叠后的偏移映射、替换描述时重置未重述的旧偏移、末尾起点取消动作和按钮语义,都直接服务于新增字段的正确性;生产态输入降级也符合已有容错路径。Web 长前缀预留动作空间属于明确的布局策略,已写入 SPEC,不是通过业务文案猜行为。这些无需删除。

验证与交付边界:

  • 当前 head 的 hosted checks 全绿;已读取关键 XCTest 的通过记录,包括纯时间首行、UTF-16/换行映射和原 Pager 隔离用例。
  • 本轮将精确 head 提取到临时目录验证:Activity 模型/校验 9 个用例通过;Web 159 个用例通过,另一个因临时目录缺 Pager 源码未运行成功,补齐相同 head 的 Pager 源码后单独重跑通过。两个新增 Web 描述用例均通过。DOM 测试不代表浏览器真实排版。
  • Android 仪器测试源码确实通过窗口发送真实触摸;API 36 的执行结果来自作者报告,本轮未重新启动模拟器或 OneKey App 验收。
  • Home History 及 gallery 调用方必须随 app-monorepo 依赖升级同步传起点;未传时默认整段可点。该消费者交付仍待落地,不能仅凭 SDK PR 的修改宣称整个 App 已交付。6.7 版本号要求也需随发布流程落实。
  • 前轮发现的 legacy 状态文字、金额符号及 Identity 动作名耦合仍属于存量独立事项,本轮未扩大到这些文件。
维度 得分
安全性 8/10
代码质量 7/10
架构合理性 8/10
完整性 7/10
加权总分 7.6/10,需修正 P1 后复审

…Android

The start was read with optInt. JSON carries any safe integer, and one
past Int range, 4294967296 for example, came back as 0: the whole
description became the action instead of none of it.

The start is read as a Long and clamped to the description length before
it is narrowed. iOS reads a 64-bit Int and Web a number, so only Android
was affected; all three have a case for it now.
The horizontal slop widened the action area by 8 units on both sides,
also on the side where the plain text before descriptionActionStart
sits. A prefix narrower than the slop, the "i" of "iRouter" with start
1, opened the action it is not part of.

The slop now reaches into blank space only and stops at plain text on
the same line. The area is built from the layout engine's own rects for
the action's character range (TextKit enclosing rects, the Android
layout's selection) instead of one box per line, so a suffix that
mixed-direction text splits into several visual runs is hit on each run
and not on the plain text between them.

An ellipsis belongs to the action while action text is visible before
it; once truncation hides the action text, nothing is left to touch.
@originalix

Copy link
Copy Markdown
Contributor

Automated review needs attention

Review of commit f7022197e6dd finished, but some comments could not be published automatically.

Publication requires a retry or human review. This is not an automated approval.

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex review

@sidmorizon

Copy link
Copy Markdown
Contributor

@codex security review

@sidmorizon

Copy link
Copy Markdown
Contributor

Devin Cloud review ↗

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T08:09:01.469619Z f702219 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sidmorizon

Copy link
Copy Markdown
Contributor

Cursor review failed.

Remote error: cursor_permission_denied: HTTP 403 Forbidden: Cloud Agent is not available for free users. Please upgrade to Pro.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

Unknown error
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cursor

cursor Bot commented Nov 13, 2026

Copy link
Copy Markdown

Skipping Bugbot: Bugbot is disabled for this repository. Visit the Bugbot dashboard to update your settings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: f7022197e6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidmorizon

Copy link
Copy Markdown
Contributor

@weatherstar
weatherstar disabled auto-merge November 13, 2026 08:15
@weatherstar
weatherstar merged commit 29f67da into main Nov 13, 2026
15 checks passed
@weatherstar
weatherstar deleted the fix/description-touch-and-overlay-scroller-ok-67219-ok-67220 branch November 13, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants