J1-PIPELINE: CommandDesk audit, security hardening, and documentation - #22
Open
OneByJorah wants to merge 13 commits into
Open
J1-PIPELINE: CommandDesk audit, security hardening, and documentation#22OneByJorah wants to merge 13 commits into
OneByJorah wants to merge 13 commits into
Conversation
added 13 commits
July 5, 2026 20:40
The RateLimiter.__init__ used =() (empty tuple) instead of ={} (empty dict)
for the _sessions field. This caused an AttributeError on the first request
because tuples don't have a .get() method.
Fixes: C1 (CRITICAL - runtime crash on first request)
The default REDIS_URL referenced postgres:5432 (PostgreSQL port) instead of redis:6379. This was a copy-paste error that would cause the health monitor to fail connecting to Redis if the env var was not set. Fixes: C2 (CRITICAL - wrong Redis URL default)
The default REDIS_URL referenced postgres:5432 (PostgreSQL port) instead of redis:6379. This was a copy-paste error that would cause the WhatsApp webhook to fail connecting to Redis if the env var was not set. Fixes: C3 (CRITICAL - wrong Redis URL default)
The Zammad adapter used requests.post(), requests.get(), and requests.patch() but never imported the requests module. Any ticket operation on Zammad would crash with NameError. Fixes: C4 (CRITICAL - NameError on Zammad operations)
Dependabot was configured for npm ecosystem but no package.json exists in the repository. This was a template vestige from the J1 repo template that would cause Dependabot errors. Fixes: D2 (DEGRADED - Dependabot ecosystem mismatch)
The standalone osTicket wrapper (osticket_tool.py) predates the adapter pattern and is superseded by ticket_platforms/osticket.py. It is not referenced by any Docker service, config, or import. Fixes: D4 (DEGRADED - dead code)
Replaced :latest tags with specific versions for reproducible builds: - searxng/searxng:2025.1.1 - n8nio/n8n:1.80.0 Fixes: D7 (DEGRADED - unpinned Docker image tags)
Adds a .dockerignore file to exclude unnecessary files from the Docker build context: .git/, secrets, models, data, IDE files, logs, reports, and non-essential directories (compose/, admin/, skills/, tools-ui/, workflows/). Fixes: D8 (DEGRADED - no .dockerignore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR publishes the complete J1-PIPELINE audit, security hardening, and documentation pass for CommandDesk. It includes four categories of changes:
🔒 Security Hardening
📋 Meta & Configuration
📊 Audit Reports (J1-PIPELINE)
📖 Documentation
Details
AUTO_MERGE: false