Repository navigation
ci: restore CI with lint and test checks - #26
Merged
Merged
Conversation
CI was moved to .github/workflows_disabled. Restored as-is it could not pass: pyproject.toml pins two private repositories by git URL (omnibioai-iam-client v0.1.4 and omnibioai-usage-client v0.1.0), and the workflow's GITHUB_TOKEN cannot read other private repositories, so the install step failed and the test suite never ran. The new .github/workflows/ci.yml installs the package with its dev extras and runs ruff and pytest (with the 95% coverage gate in pyproject.toml) on Python 3.11 for pushes and pull requests to main. A repository secret, PRIVATE_DEPS_TOKEN, is used only to rewrite the URLs of those two dependencies; the job fails early with an explicit error if it is unset. Permissions are read-only, and the publish workflows are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016nxi4bp7DP1ancERNUUfzj
Collaborator
Author
|
The failing Lint & test (Python 3.11) check stops at its first guard, as intended: Blocker: add the repository secret Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was moved to
.github/workflows_disabled, so pushes and PRs tomainran no checks.Why the old workflow could not pass:
pyproject.tomlpins two private repositories by git URL,omnibioai-iam-client@v0.1.4andomnibioai-usage-client@v0.1.0. A workflow'sGITHUB_TOKENcannot read other private repositories, so the install step failed and the tests never ran. The "missing httpx" errors were a symptom of that failed install.New
.github/workflows/ci.ymlmain.-e ".[dev]", then runsruff check .andpytestwith the 95% coverage gate frompyproject.toml, on Python 3.11.PRIVATE_DEPS_TOKEN, a fine-grained token with Contents: read on those two repositories only. It is used solely to rewrite those two dependency URLs. If it is unset, the job fails at once with an explicit error.contents: read). The existing publish workflow is unchanged.Before merging: add the
PRIVATE_DEPS_TOKENsecret under Settings → Secrets and variables → Actions. Until then this PR's CI fails at the install step, by design.Verified locally: a fresh Python 3.11 environment with
pip install -e ".[dev]"resolved both private dependencies at their pinned tags;ruff check .passes; 598 tests pass at 95.14% coverage.🤖 Generated with Claude Code
https://claude.ai/code/session_016nxi4bp7DP1ancERNUUfzj
Generated by Claude Code