Repository navigation
ci: fail the required test check when the build or test matrix fails - #684
Merged
Merged
Conversation
desruc
changed the title
liamhughes
approved these changes
Nov 2, 2026
Comment on lines
10
to
11
| paths-ignore: | ||
| - '**/*.md' |
Contributor
There was a problem hiding this comment.
Consider removing this to avoid Markdown only changes being stuck due to required checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're moving this repo onto the shared Renovate config in #681. That config auto-merges some updates once the required checks pass. The required check here is
test. It only runsechoand waits on the test matrix.If the build or a matrix leg fails, GitHub skips
test. A skipped required check counts as passing. So a broken update could auto-merge.This makes
testalways run on pull requests. It fails unless the build and every matrix leg succeeded. The check name stays the same so branch protection doesn't need to change.This should merge before #681.