Get HCLParser's CI build running on .NET 10 - #21
Open
matt-richardson wants to merge 2 commits into
Open
Conversation
OctoVersion.Tool was renamed to Octopus.OctoVersion.Tool; the old package id no longer has the pinned 0.2.963 version available, breaking restore. Bumped to the latest available release. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Nuke.Common 6.0.1 clones its tool settings with BinaryFormatter, which .NET 9 removed from the runtime, so every DotNet* task threw PlatformNotSupportedException once the build project moved to net10.0. 6.0.1 also only knows the pre-rename OctoVersion.Tool package id. Ports Build.cs to the Nuke 10 APIs, matching the shape used in Ocl. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-enabling CI here after DPT-2500 (Drop build-base-dotnet image) moved this config off the shared
build-base-dotnetimage. That turned out to be the first time the build had run since November 2022, and two things had rotted in the meantime.OctoVersion.Toolwas renamed toOctopus.OctoVersion.Tool, and the pinned0.2.963no longer resolves at all, so restore failed before anything else got a chance to.Fixing that exposed the actual blocker:
Nuke.Common6.0.1 clones its tool settings withBinaryFormatter, which .NET 9 removed from the runtime outright. Once the build project moved tonet10.0, everyDotNet*task threwPlatformNotSupportedException. Staying on Nuke 6 isn't an option — the upgrade is what makes net10 viable, and it also happens to be what makes the package rename correct, since Nuke only learned the new OctoVersion package id in 7.0.Build.csfollows Ocl's shape, which is the closest match in the org: same Nuke 10.1.0, same net10.0 build project. Also drops aJetBrains.ReSharper.GlobalToolspin from 2021 that no target ever referenced.Verified locally end to end — 420 passed, 1 skipped, which matches the 421 anchor TeamCity fails builds against. Worth knowing that this config's VCS trigger is disabled, so the PR won't build on its own; it needs a manual run against the branch.
Relates to RDO-101 (HCLParser targets end-of-life .NET (net8.0)).