Repository navigation
Add approval API action routes - #73
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1c992cd6a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @app.post("/approvals/{approval_id}/approve", response_model=ApprovalRequest) | ||
| def approve_approval(approval_id: str) -> ApprovalRequest: | ||
| try: | ||
| return ApprovalStore(root).approve(approval_id) |
There was a problem hiding this comment.
When an approval is resolved through either new HTTP route, the store is mutated and the function returns without appending a PATCH_APPROVED or PATCH_REJECTED event to ActivityRecordStore. The equivalent CLI paths explicitly append these events in src/sovereign_cortex/cli.py, so API-driven decisions leave the activity JSONL lifecycle incomplete and cannot be correlated or replayed with the original approval request.
Useful? React with 👍 / 👎.
Summary
Adds the remaining local approval API endpoints.
Changes
Completes #46.
Validation
CI should run on this PR.