Repository navigation
Draft Phase 3 event topic conventions - #71
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0eee338f7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Proposed topic names use dot-separated segments: | ||
|
|
||
| ```text | ||
| sovereign.<workspace>.<domain>.<event> | ||
| ``` |
There was a problem hiding this comment.
When these conventions are implemented with the stated Solace stack, dots leave the entire address in one topic level, so consumers cannot independently wildcard workspace, domain, or event as this hierarchy intends. Solace uses / to separate routable topic levels (https://docs.solace.com/Cloud/Event-Portal/event-portal-topic-addresses.htm); define these addresses with that delimiter or explicitly document an adapter translation.
Useful? React with 👍 / 👎.
| sovereign.<workspace>.approval.requested | ||
| sovereign.<workspace>.approval.approved | ||
| sovereign.<workspace>.approval.rejected |
There was a problem hiding this comment.
When an adapter publishes the approval events currently emitted by cli.py, these names provide no deterministic topic: the canonical enum contains PatchApproved and PatchRejected, while the document defines approval.approved and approval.rejected and omits the corresponding patch topics. Since the document says topic names derive from canonical event types and EventEnvelope remains authoritative, either use topics corresponding to those enum values or document the explicit mapping; the same inventory should cover PolicyChecked.
Useful? React with 👍 / 👎.
Summary
Adds a docs-only draft of Phase 3 event topic and envelope conventions.
Changes
Closes #49.
Validation