Repository navigation
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This stacked PR turns ModelMap's canonical corpus into stable generated read models for browsing, graph traversal, and encyclopedia pages without duplicating canonical facts.
Catalog view
Adds
tools/build_catalog.py, which deterministically exports canonical model families, releases, variants, techniques, organizations, products, and other browseable entities with type counts and source record paths.Knowledge graph view
Adds
tools/build_graph.pywithcoreandallscopes. Graph edges are materialized only from canonical relationship records; the generator never derives new ancestry or influence edges. Core mode limits nodes to browseable encyclopedia entities, while all mode retains evidence-layer nodes as well.Entity-page view
Adds
tools/build_entity.py <canonical-id>, which assembles one canonical entity with direct claims, events, incoming/outgoing relationships, concrete variants, variant-level claims/events, and related product systems. This provides the read model for future model, technique, and organization pages.Contracts and regression tests
Adds schemas for catalog, graph, and entity outputs plus regression tests for deterministic sorting, schema validity, graph endpoint integrity, full-graph edge retention, and release/variant/product scope. A GPT-5.6 test explicitly verifies that Sol/Terra/Luna remain variants while
ultraremains a related product system.CI
Validation builds the full timeline and every 2017–2026 year view, then generates the catalog, core graph, full graph, and a representative GPT-5.6 entity view on every PR. Current head
6f25886is mergeable and green in run #41.Review note
Codex code-review quota remains exhausted, so this head is validated by automated contracts/regression tests and manual inspection rather than a fresh Codex review.
Stack
Base:
atlas-foundations-2017-2022-v0.1(PR #9)Head:
atlas-generated-views-v0.1