fix: guard openspec-plan bash permissions#13
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openspec *allowance from fix: allow openspec CLI for openspec-plan #10 while blocking generic bash write bypassesRoot cause
The bash allowlist permitted broad read-oriented patterns such as
cat *,echo *,find *, and git read commands. Since OpenCode permission rules are last-match-wins wildcard matches against the command string, write-capable variants like output redirection could still match an allow rule unless a later deny rule catches them.Current OpenCode routes the
writetool through theeditpermission; the new test also locks the implementation-file deny behavior for that path.Addresses #12 and strengthens #6.
Validation
bun testbun run buildbunx tsc --noEmitgit diff --check