core/deadline: increase sync message deadline - #4610
Merged
Conversation
|
pinebit
approved these changes
Jul 28, 2026
pinebit
left a comment
pinebit
left a comment
Collaborator
There was a problem hiding this comment.
Assuming we tested this, approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4610 +/- ##
==========================================
- Coverage 57.57% 57.56% -0.02%
==========================================
Files 246 246
Lines 33675 33675
==========================================
- Hits 19389 19385 -4
- Misses 11848 11855 +7
+ Partials 2438 2435 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
KaloyanTanev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase sync message deadline. This is done as after the deadline hits, the aggregated sync message signatures are cleaned from the DB (previously at 8s + 1s margin). However, the sync contribution does need them as part of the data, so sometimes, under specific network conditions or VC types, the contribution might take a bit more than 9s and the sync message is missing by then.
category: bug
ticket: none