Repository navigation
ci: run the required docs checks on every pull request - #1405
Open
sonukapoor wants to merge 1 commit into
Open
sonukapoor wants to merge 1 commit into
sonukapoor wants to merge 1 commit into
Conversation
Two of the five required checks come from the docs workflow, which only ran when a pull request touched website/. A source-only pull request therefore never got them, so every merge went through the admin override, which skips all five checks. The workflow now runs on every pull request. A first job decides whether website/ or this workflow changed, and when nothing did the build job passes without installing or building. Pushes to main keep the path filter, so a source-only merge still does not redeploy. The pages concurrency group and the pages and id-token permissions now apply to the deploy job only. Pull request runs get a group per pull request, so website pull requests opened close together no longer replace each other's pending run. Closes #1404
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two of the five checks branch protection requires come from the docs workflow, and that workflow only ran when a pull request touched
website/. So a pull request that changed only source code never got those two checks, could never satisfy protection, and every merge went through the admin override, which skips all five checks rather than just the two that could not run.The workflow now runs on every pull request. A first job works out whether anything under
website/, or this workflow itself, changed. When nothing did,Build Docusaurus sitepasses without installing or building, so the required check exists and says plainly that there was nothing to build. Website pull requests build exactly as before, and a broken build still fails. Pushes tomainkeep the path filter, so a source-only merge still does not redeploy the site.The shared
pagesconcurrency group, along with thepages: writeandid-token: writepermissions, now belongs to the deploy job alone. Pull request runs get a group of their own, so website pull requests opened close together stop replacing each other's pending run, which is how #1369 got stuck.No branch protection setting changes. This pull request edits the workflow, so it gets a real site build itself; the first source-only pull request after it merges is the check of the other half.
Closes #1404