Repository navigation
Conversation
sonukapoor
left a comment
There was a problem hiding this comment.
Two of the three changes here are right and I checked them against the code rather than the docs: there are thirteen rules on main, OA001 through OA011 plus PD001 and PD002, the hygiene guide already documents all thirteen, and they all run under that flag. So the CLI reference and the index pointer were both stale and your replacements are accurate.
The press page change is the one I need you to drop. That paragraph is our summary of someone else's published review, not a description of the current product, so the number in it is a fact about what Suphi covered in August rather than a figure to keep current. OA011 did not ship until the end of September, so the review cannot have covered thirteen rules and saying it did would misstate what he wrote.
Everything else is good to go. Drop that one line and I will take it.
b4c3d80 to
6931ca9
Compare
|
Removed the |
sonukapoor
left a comment
There was a problem hiding this comment.
That is it, thanks. I checked the rule identifiers against the code rather than against the hygiene guide, since the guide could have been stale in the same direction: there are thirteen on main, OA001 through OA011 plus PD001 and PD002, and they all run under that flag. So both of your replacements are accurate and those two pages now agree with what ships.
Dropping the press page change was the right call. Approved.
What changed and why
The override-hygiene docs still described the older rule set. The scanner ships 11 OA rules plus 2 PD rules (verified against
src/cli/help.ts), but several pages referencedOA001-OA008,OA001-OA009, or "eleven" rules.This updates:
website/docs/cli-reference.md(--check-overridesdescription and the rule-reference link)website/docs/index.mdwebsite/docs/press.mdAll now reference
OA001-OA011, PD001-PD002/ 13 rules.Closes #1373