fix(redact): mask secrets in mixed interpolations - #171
Open
gulamovzavohir02-glitch wants to merge 1 commit into
Open
gulamovzavohir02-glitch wants to merge 1 commit into
gulamovzavohir02-glitch wants to merge 1 commit into
Conversation
Signed-off-by: Jasur Gulyamov <gulamovzavohir02@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
DockSec currently treats every secret-key value beginning with
${or$(as a safe placeholder. This lets literal secrets in Compose defaults and mixed interpolation values pass through the pre-LLM redaction layer unchanged.This change recognizes only a complete
${VARIABLE}reference as a placeholder. Values such as${DB_PASSWORD:-hunter2},${USER}:hunter2, and command substitutions are now fully masked. Quoted pure variable references and empty assignments retain their existing behavior.Closes #170
Type of Change
How Has This Been Tested?
Added regression tests for:
:-and-Validation:
pytest tests/ -q— 273 passed, 2 skippedblack --check docksec/redact.py tests/test_redact.pyisort --check-only docksec/redact.py tests/test_redact.pymypy docksec/redact.pygit diff --checkTest Configuration:
Checklist
Screenshots (if applicable)
Not applicable.
Related Issues / PRs
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.