Skip to content

contributing: add SPDX-License-Identifier tags in lib - #7920

Open
nilason wants to merge 4 commits into
OSGeo:mainfrom
nilason:fix_spdx_license_in_lib
Open

nilason wants to merge 4 commits into
OSGeo:mainfrom
nilason:fix_spdx_license_in_lib

Conversation

@nilason

@nilason nilason commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Adds SPDX-License-Identifier to all *.c, *.cpp, *.h, *.py, *.sh, Makefile and CMakeLists.txt files in lib directory (where this tag is missing). The lib/external directory is excluded from this.

In some cases, where explicitly stated, SPDX-FileCopyrightText is also added. But that tag will need a follow up PR for the remaining files.

Note, for the files:

  • lib/gis/strlcat.c
  • lib/gis/strlcpy.c
  • lib/vector/dglib/avl.c
  • lib/vector/dglib/tavl.c

there is a double license, which I believe (but not positively) should be expressed with AND (e.g. BSD-2-Clause AND GPL-2.0-or-later and LGPL-3.0-or-later AND GPL-2.0-or-later). These files contain mainly external code, with minor additions/modifications by GRASS devs.

Other than this latter issue, this should be pretty straightforward.

I deliberately didn't remove any existing license or copyright text (see https://github.com/OSGeo/grass/blob/main/doc/development/rfc/legal_aspects_of_code_contributions.md).

@github-actions github-actions Bot added vector Related to vector data processing raster Related to raster data processing temporal Related to temporal data processing Python Related code is in Python C Related code is in C C++ Related code is in C++ database Related to database management libraries display imagery tests Related to Test Suite raster3d CMake labels Sep 15, 2026
@nilason

nilason commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

there is a double license, which I believe (but not positively) should be expressed with AND (e.g. BSD-2-Clause AND GPL-2.0-or-later and LGPL-3.0-or-later AND GPL-2.0-or-later). These files contain mainly external code, with minor additions/modifications by GRASS devs.

Or should these be simply BSD-2-Clause and LGPL-3.0-or-later respectively?

@nilason

nilason commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Or should these be simply BSD-2-Clause and LGPL-3.0-or-later respectively?

I updated doing just that.

@nilason
nilason force-pushed the fix_spdx_license_in_lib branch from e01d0a6 to 42c8813 Compare September 18, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Related code is in C C++ Related code is in C++ CMake database Related to database management display imagery libraries Python Related code is in Python raster Related to raster data processing raster3d temporal Related to temporal data processing tests Related to Test Suite vector Related to vector data processing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant