Skip to content

Remove the dark mode toggle that only changes code highlighting - #150

Merged
petrasovaa merged 1 commit into
OSGeo:mainfrom
Valyrian-Code:remove-theme-toggle
Nov 6, 2026
Merged

petrasovaa merged 1 commit into
OSGeo:mainfrom
Valyrian-Code:remove-theme-toggle

Conversation

@Valyrian-Code

Copy link
Copy Markdown
Contributor

Fixes #137.

The dark: logo mappings in brand/_brand.yml make Quarto add a dark mode toggle, but there is no dark theme, so the toggle only swaps the code highlighting and makes the code unreadable. This removes them, as suggested in the issue.

Before, with the toggle clicked:
before-toggle-clicked

After:
after-fix

Copilot AI balanced review requested due to automatic review settings November 6, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@wenzeslaus

Copy link
Copy Markdown
Member

+1, but we should provide the dark theme eventually. @cwhite911 may have some comments on what's already there. Well set up Claude design may know enough about our branding.

@petrasovaa
petrasovaa merged commit 0c4c6dd into OSGeo:main Nov 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dark/light theme toggle not working

5 participants