Skip to content

Modifications to i.image.bathymetry to return original functionality - #321

Open
dnewcomb wants to merge 1 commit into
OSGeo:grass8from
dnewcomb:i.image.bathymetry_fix
Open

dnewcomb wants to merge 1 commit into
OSGeo:grass8from
dnewcomb:i.image.bathymetry_fix

Conversation

@dnewcomb

Copy link
Copy Markdown
Contributor

This will restore the previous options for adaptive and bisquare kernel as described in the manual page.

@neteler
neteler requested a review from lucadelu December 27, 2020 22:58
#predict = g.read_command("g.tempfile", pid=os.getpid()).strip() + '.txt'
#replace dynamic variable of predict with a static filename until g.tempfile formatting
#is cross platform
predict="bathytemp.txt"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use tempfile library to get a temporary name? something like os.path.join(tempfile.gettempdir(), os.getpid()).strip() + '.txt') should work

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, maybe better

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucadelu lucadelu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems good, I suggest only a small change

@echoix
echoix changed the base branch from master to grass8 July 18, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants