Repository navigation
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Existing zero-byte destinations cannot be replaced on Windows because all three download paths use os.rename.
1 open finding
What changed in this PR
Addresses #209 by staging ERA5 and hindcast downloads in temporary files to avoid exposing partial downloads.
Changes:
- Downloads to
.partfiles and retries existing zero-byte destinations. - Adds tests for skipping, downloading, and ERA5 retrieval failures.
- Enables forecasts in the default configuration.
| File | Description |
|---|---|
| scripts/tests/test_get_era5.py | Tests ERA5 download and failure handling. |
| scripts/tests/test_get_any_hindcast.py | Tests both hindcast download modes. |
| scripts/get_era5.py | Adds temporary downloads and zero-byte retries. |
| scripts/get_any_hindcast.py | Adds temporary downloads and zero-byte retries in both modes. |
| osop_config.yml | Enables the forecast workflow. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


closes #209 - adds temporary filenames and also checks if files are zero size