Repository navigation
fix: prevent slow FAQ parsing, stale drafts, and dropped responsibilities - #8
Merged
Merged
Conversation
Avoid regex backtracking on whitespace-heavy input, discard stale draft responses and errors after source or mode changes, and distinguish client/provider responsibilities during topic deduplication. Add regression coverage and an unreleased changelog entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitespace-heavy text within the 50,000-character limit could cause excessive regex backtracking. A pending draft request could also restore old results after the source or mode changed, and topic deduplication dropped provider responsibilities when client responsibilities were already present.
This change:
Validation:
mvn -B -ntp verify: 38 Java tests passed.node --test src/test/js/*.test.cjs: 12 JavaScript tests passed.Public-hosting controls such as overall JSON body limits, rate limiting, response security headers, and isolated document parsing remain follow-up work.