[19.0][MIG] base_user_show_email: Migration to 19.0 - #996
Open
jcadhoc wants to merge 21 commits into
Open
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: server-auth-16.0/server-auth-16.0-base_user_show_email Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-base_user_show_email/it/
Core renders the login label as:
<label for="login" class="form-label d-flex justify-content-between">Email</label>
and the user switcher component portals its "Choose a user" button
straight into that element (web/static/src/core/user_switch/user_switch.xml,
`t-portal="'label.form-label'"`).
This module replaced the whole label to rename it to "Login" and dropped
`d-flex justify-content-between` in the process, so the portalled button
lost its spacing and ended up glued to the label text
("LoginChoose a user"). The password label right below, untouched by this
module, keeps rendering correctly.
Keep the classes core sets on the label so the switcher button is laid
out as intended.
OCA-git-bot
added
series:19.0
mod:base_user_show_email
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #867 (same branch, plus one fix commit), which the stale bot closed
after 4 months without review. Migration work is @augusto-weiss'; this PR only
adds a fix on top and reopens the discussion.
Migration
Standard migration of
base_user_show_emailto 19.0: manifest version bump andremoval of the
res_users_view.xmlform-view tweaks that core now covers.Fix on top
On the login page the renamed label and the core user switcher button render
glued together as
LoginChoose a user.Core renders the label as:
and the user switcher portals its "Choose a user" button straight into that
element —
addons/web/static/src/core/user_switch/user_switch.xml,t-portal="'label.form-label'". This module replaces the whole label to renameit to "Login" and dropped
d-flex justify-content-betweenalong the way, so theportalled button loses its spacing. The password label right below, untouched by
this module, keeps rendering correctly.
The switcher only appears once the browser has stored logins for the database,
so the glitch is only visible to returning users.
Same fix for 18.0, where the module is already merged: #995
Test plan
base_user_show_email./web/login: the "Choose a user" button should sit at the right endof the label row, aligned the same way as "Reset password" is on the
password label.
Internal ref: https://www.adhoc.inc/odoo/project.task/71192