[18.0][FIX] vault: do not present exhausted inboxes as writable - #989
Open
jans23 wants to merge 1 commit into
Open
[18.0][FIX] vault: do not present exhausted inboxes as writable#989jans23 wants to merge 1 commit into
jans23 wants to merge 1 commit into
Conversation
jans23
force-pushed
the
18.0-fix-vault-inbox-ux
branch
2 times, most recently
from
August 24, 2026 13:56
8130bb6 to
9e9f671
Compare
jans23
marked this pull request as ready for review
August 24, 2026 14:01
fkantelberg
suggested changes
Sep 2, 2026
fkantelberg
left a comment
fkantelberg
left a comment
Member
There was a problem hiding this comment.
This includes additional changes from another PR. Still some notes.
| name="inbox_link" | ||
| widget="url" | ||
| invisible="not writable" | ||
| /> |
Member
There was a problem hiding this comment.
You can increase the access again or set a different expiration to make it writable again. Highlighting it that it's not writable is good but maybe better done with a ribbon.
<widget name="web_ribbon" title="Readonly" bg_color="text-bg-danger" invisible="not writable"/>For the list view it might be better to use a decoration.
jans23
force-pushed
the
18.0-fix-vault-inbox-ux
branch
from
September 2, 2026 11:59
9e9f671 to
947b394
Compare
An inbox that can no longer be written to (access counter at 0 or expired) still showed its writable inbox link, and submitting to it silently did nothing while the form reported 'Successfully stored'. This is misleading for received/delivered secrets which are created with accesses = 0. - Add a computed 'writable' flag (accesses left and not expired) and hide the inbox link in the list and form views when it is not writable. - Make the controller report 'This link is no longer active' when store_in_inbox performs no write instead of a false success message. - Cover the exhausted-inbox submit path in the controller test.
jans23
force-pushed
the
18.0-fix-vault-inbox-ux
branch
from
September 2, 2026 12:18
947b394 to
2d2fbe1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An inbox that can no longer be written to (access counter at 0 or expired) still showed its writable inbox link, and submitting to it silently did nothing while the form reported 'Successfully stored'. This is misleading for received/delivered secrets which are created with accesses = 0.
This depends on #987