[FIX] password_security: avoid blocking module installation - #986
Open
luisg123v wants to merge 1 commit into
Open
[FIX] password_security: avoid blocking module installation#986luisg123v wants to merge 1 commit into
luisg123v wants to merge 1 commit into
Conversation
Users created from data files can have passwords that do not comply with the configured policy, which causes modules that define such users to fail during installation, even demo data. To fix this, the policy check is skipped while loading data files. Note that Tests are unaffected because users created there are through the ORM, so the policy is still covered. Closes OCA#865
luisg123v
force-pushed
the
19.0-password_security_skip_demo-luisg
branch
from
August 22, 2026 20:48
5ac60f4 to
79eaad9
Compare
Contributor
Author
|
Hi @moylop260, Could you review, please? CC @isaako34, @desdelinux |
moylop260
approved these changes
Aug 25, 2026
Contributor
|
Approve since that I have a similar issue using this same way xd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users created from data files can have passwords that do not comply with the configured policy, which causes modules that define such users to fail during installation, even demo data.
To fix this, the policy check is skipped while loading data files.
Note that Tests are unaffected because users created there are through the ORM, so the policy is still covered.
Closes #865