[18.0][IMP] rest_log: add profiling - #589
Conversation
|
Hi @simahawk, |
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
early review, to be tested.
|
I've reworked it and simplified a bit. How it works:
UPDATED: 12/02 |
66f3662 to
524d239
Compare
524d239 to
582e759
Compare
simahawk
changed the title
179fdd3 to
c3258c6
Compare
|
using it live since a while: works fine :) |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
Live on prod since months 🟢
simahawk
removed
the
stale
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-589-by-simahawk-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Unrelated build issue #637 |
This allows to use the same syntax than the existing one from rest.log.active to define other config parameters.
Leverage ir.profile machinery to track what happens when a user calls some rest services. Since profiling can be done only for a single user at a time the system parameter rest.log.profiling.uid has to be defined with the ID from res.users whose calls need to be profiled. Moreover, system parameter rest.log.profiling.conf can be defined using the syntax from rest.log.active to fine tune which requests will trigger the profiling for the user defined by the previous parameter. To note, once a request is identified to start the profiling, all incoming requests from the user will be profiled until the timeout duration defined by rest.log.profiling.duration is reached.
Gives better control on how to profile.
c3258c6 to
d17e2ae
Compare
5 participants
[REF] rest_log: Add hooks to read configuration from system params
This allows to use the same syntax than the existing one from
rest.log.active to define other config parameters.
[IMP] rest_log: Allow to profile requests through rest services
Leverage ir.profile machinery to track what happens when a user
calls some rest services.
Since profiling can be done only for a single user at a time the
system parameter rest.log.profiling.uid has to be defined with
the ID from res.users whose calls need to be profiled.
Moreover, system parameter rest.log.profiling.conf can be defined
using the syntax from rest.log.active to fine tune which requests
will trigger the profiling for the user defined by the previous
parameter.
To note, once a request is identified to start the profiling, all
incoming requests from the user will be profiled until the timeout
duration defined by rest.log.profiling.duration is reached.