[FIX] use authenticated GitHub API to check maintainers in other branches - #357
Open
yajo wants to merge 1 commit into
Open
[FIX] use authenticated GitHub API to check maintainers in other branches#357yajo wants to merge 1 commit into
yajo wants to merge 1 commit into
Conversation
yajo
force-pushed
the
fix-226-maintainer-other-branches-auth
branch
from
July 30, 2026 15:48
b066222 to
060b0c2
Compare
Collaborator
|
Could you take a look on red CI ? Thanks ! |
legalsylvain
marked this pull request as draft
July 30, 2026 17:47
yajo
force-pushed
the
fix-226-maintainer-other-branches-auth
branch
from
July 31, 2026 11:16
060b0c2 to
1480a4c
Compare
yajo
marked this pull request as ready for review
July 31, 2026 11:17
Member
Author
|
Done, was just formatting. |
Member
Author
|
Any chances to review this? cc @sbidoul |
Member
|
And this is more important since https://github.com/orgs/community/discussions/206581 |
Member
|
Looks good, but why keep the unauthenticated variant? This adds bloat for no reason that I can see. |
Member
Author
|
You mean to set the github token as required? |
Member
|
Yes. But now that I think of it, I'm not even sure we have ever had a 429 on these requests. |
yajo
force-pushed
the
fix-226-maintainer-other-branches-auth
branch
from
September 9, 2026 09:06
1480a4c to
39d489e
Compare
Member
Author
|
Well, I've changed it and now the token is required. |
yajo
force-pushed
the
fix-226-maintainer-other-branches-auth
branch
2 times, most recently
from
September 10, 2026 09:28
a908905 to
fddf338
Compare
…rs in other branches When a maintainer tried to merge or rebase a migration PR, the bot looked for maintainers in other branches by downloading each addon manifest from raw.githubusercontent.com. That endpoint is unauthenticated and subject to rate limiting, transient errors and caching issues, which made the check fail intermittently (see OCA#226). Since the bot already requires a GitHub token for all its operations, keep only the authenticated GitHub Contents API path and drop the raw URL fallback. This removes unnecessary code and avoids preserving the very failure mode this fix addresses. Fixes OCA#226 Assisted-by: OpenCode + Kimi k2.7-code
yajo
force-pushed
the
fix-226-maintainer-other-branches-auth
branch
from
September 10, 2026 10:21
fddf338 to
d4640cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a maintainer tried to merge or rebase a migration PR, the bot
looked for maintainers in other branches by downloading each addon
manifest from raw.githubusercontent.com. That endpoint is unauthenticated
and subject to rate limiting, transient errors and caching issues, which
made the check fail intermittently (see #226).
With this change, the authenticated GitHub session already used by the
bot is reused to read manifests via the GitHub Contents API. The previous
raw URL request is kept as a fallback in case the API is unavailable.
Fixes #226
Assisted-by: OpenCode + kimi-k2.7-code