Conversation
|
Hi @sbidoul, |
4143042 to
1b1283c
Compare
|
I've force/push a refactor to expose |
AnizR
left a comment
There was a problem hiding this comment.
Code lgtm
Tested on runboat
|
Not looked at the code yet but a question: what is the scope of the cache, how is memory managed, is there a risk of memory leak? |
Cache is scoped to the Form Controller so as soon user will click on a new menu, the allocated RAM should be available to the GC. |
When navigating away from a MIS report via drilldown links and returning using the breadcrumb, active search filters and pivot date were lost. This commit preserves the report widget state across view navigation: - Register `useSetupAction` in `MisReportWidget` to export search model state and pivot date when leaving the controller. - Forward `props.state` to `env.config.state` in `FormController` so that restored controller state is accessible during component `willStart`. - Hydrate `searchModel` and `pivot_date` upon view restoration. - Add JS tour `mis_report_drilldown_tour` and HttpCase test `TestMisReportWidgetTour` to validate filter preservation end-to-end. Assisted-by: Gemini 3.6 Flash
Allow caching computed report data in browser memory during drilldown navigation to prevent recomputing the report when returning via breadcrumbs. - Add `widget_cache_report_on_drill_down` boolean field (default False) to `mis.report.instance` and its form view. - Export `cachedReportData` in `MisReportWidget` local state when active. - Reuse cached matrix data upon breadcrumb restoration, skipping the `compute` RPC call. - Invalidate cache automatically on filter or pivot date updates. - Add `test_mis_report_drilldown_cache_tour` test. - Add usage documentation Assisted-by: Gemini 3.6 Flash
1b1283c to
e527746
Compare
- Add mis_report_instance_preview_action to fix back button
navigation when opening preview from list view.
- Use useSetupAction({ getGlobalState }) and FormController patch to
preserve search filters, pivot date, and cached report data
upon browser back (popstate) navigation.
Assisted-by: Gemini 3.6 Flash
|
I've close #826 because this PR was based on it. Also I've add the third commit that fix coming back from drill-down using browser navigation buttons |
8882b31 to
07d1ba5
Compare
|
hello !
When we do control on a lot of clients databases, this takes a lot of time and makes us scroll a lot. Any idea if this fix would help or if this is something different? |
Hi @vdewulf :) ! Thanks for reporting this, I've test on a customer instance where this PR is installed, unfortunately I've reproduce the behavior so at the moment this PR doesn't seems to scroll down to the clicked cell while coming back from a drilldown ! (on that instance we have project module that play with sticky column and other css stuff that I'm not 100% sure if that could be different without those project modules). Anyway I think this PR is large enough for review and if getting stable, I would suggested to report the issue if not already present or do it in a new PR on top of this one ! Definitively a good idea, I already imagine a css animation to highlight the clicked cell few seconds 🌟 |
When navigating away from a MIS report via drilldown links and returning using the breadcrumb, active search filters and pivot date were lost.
navigation to prevent recomputing the report when returning via breadcrumbs (this feature is opt out by default for consistency with current version).
Capture.video.du.2026-08-26.17-26-40.mp4