[18.0] [IMP] edi_party_helper: make endpoint category configurable + use scheme + ease attributes override - #339
Open
simahawk wants to merge 3 commits into
Open
[18.0] [IMP] edi_party_helper: make endpoint category configurable + use scheme + ease attributes override#339simahawk wants to merge 3 commits into
simahawk wants to merge 3 commits into
Conversation
- `_get_identity()` now renders `schemeID` from the id_category's new `scheme` field (falls back to `code`), so EDI/UBL output can use an external coding-scheme value distinct from the category's internal code (e.g. Peppol ICD "0088" for a GLN category coded "GLN").
- New `edi.exchange.type.endpoint_partner_category_id` (output-only in
the form view): when set, `_get_endpoint()` derives `EndpointID` from
the partner's id_number in that category, instead of always `{}`.
- `EDIParty` is now a `MutableMapping` instead of a read-only `Mapping`:
`party["key"] = value` / `party.update(...)` work to override computed
attributes (name/identifiers/endpoint/lang) after construction.
Item assignment compiles to `STORE_SUBSCR`, allowed under `safe_eval`,
unlike plain attribute assignment (`STORE_ATTR`, forbidden there) - so
this also works from a `safe_eval`-restricted context such as an
`edi.exchange.template.output` `code_snippet`. Item deletion is not
supported.
Tests added for all of the above, including one that exercises the
item-assignment path through an actual `safe_eval.safe_eval()` call to
confirm it works where attribute assignment doesn't.
simahawk
force-pushed
the
18-party-data-imp
branch
from
September 8, 2026 09:36
866499e to
382c734
Compare
ivantodorovich
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on