[17.0][MIG] edi_exchange_deduplicate_oca: Migration to 17.0 - #128
[17.0][MIG] edi_exchange_deduplicate_oca: Migration to 17.0#128SilvioC2C wants to merge 7 commits into
Conversation
SilvioC2C
changed the title
a9a366c to
53453ed
Compare
Currently translated at 100.0% (12 of 12 strings) Translation: edi-framework-16.0/edi-framework-16.0-edi_exchange_deduplicate_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-16-0/edi-framework-16-0-edi_exchange_deduplicate_oca/it/
53453ed to
ae65e1f
Compare
ae65e1f to
01ee2a9
Compare
01ee2a9 to
2cb5b5f
Compare
Ricardoalso
left a comment
Ricardoalso
left a comment
There was a problem hiding this comment.
Small comment otherwise LGTM
| @@ -39,7 +39,7 @@ def create(self, vals_list): | |||
|
|
|||
| def _edi_get_duplicates(self, count=None): | |||
There was a problem hiding this comment.
Should we not set the boolean False for the count parameter instead of None ?
There was a problem hiding this comment.
Well, we only use it as a check for deciding whether we're gonna use search() or search_count(), so as long as it can be evaluated as a boolean, it doesn't make much difference, any False-ish default value should be fine 😄
There was a problem hiding this comment.
Indeed but I find it a bit misleading and in the search method back in V16, the default value was False
But this is just design 😄
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
|
Hello dear @OCA/edi-framework-maintainers, could you please reopen this PR and apply the "no stale" label? |
1 similar comment
|
Hello dear @OCA/edi-framework-maintainers, could you please reopen this PR and apply the "no stale" label? |
OCA-git-bot
added
mod:edi_exchange_deduplicate_oca
github-actions
Bot
removed
the
stale
|
Hello @ivantodorovich @jcoux @vvrossem can you pls take a look? |
|
Hello @OCA/edi-framework-maintainers can you take a look and possibly trigger merge? |
8 participants
No description provided.