Repository navigation
[19.0][IMP] website_sale_slides_portal: improve course access from portal - #35
Conversation
OCA-git-bot
added
series:19.0
mod:website_sale_slides_portal
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Thanks @pilarvargas-tecnativa — reviewed this forward-port of the course-access improvements. A few inline notes: mostly polish, plus two behaviour questions (clipboard guard and the copy button on single-registration rows).
In return, would you be so kind as to review my #20 ? Thank you!
|
@cristina-hidalgo-tecnativa @rrebollo Thanks for the review I would keep the button available regardless of the number of registrations. It only copies the invitation URL and does not grant additional registrations. When the single registration has already been consumed, opening the link shows that no registrations are available and prevents further enrollment. There is no functional reason to restrict the button to courses with multiple registrations. Moreover, this behavior was requested and validated by the customer and is already in use in production. |
a32f9cf to
7803bcb
Compare
Make course names link directly to their corresponding course and add an action to copy the invitation link to the clipboard. Provide visual feedback after copying the invitation link and improve the courses portal breadcrumbs. TT64723
7803bcb to
932b113
Compare
cristina-hidalgo-tecnativa
left a comment
cristina-hidalgo-tecnativa
left a comment
There was a problem hiding this comment.
Code reviewed and tested locally and on runboat. LGTM!
|
/ocabot merge minor |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c6647a0. Thanks a lot for contributing to OCA. ❤️ |
6 participants
fwp 30b6708
Make course names link directly to their corresponding course and add an action to copy the invitation link to the clipboard.
Provide visual feedback after copying the invitation link and improve the courses portal breadcrumbs.
@Tecnativa TT64723
@eduezerouali-tecnativa @cristina-hidalgo-tecnativa please review