[18.0][IMP] subscription_oca : add a setting to choose if the subscription …

[cvinh]

…will start automatically when sale order is confirmed or not

[luisDIXMIT]

Code review and LGTM!

[rrebollo]

From a technical perspective, LGTM.

Would you be open to adding a test covering the change you introduced to the "standard" feature? Before this PR, my understanding from the code is that every newly created subscription automatically started. Now, with your setting, that won't happen by default.

I think adding a test would be a good safety measure—let's see how it goes. You can ping me then.

Also, would you be so kind to review my #1410 in return?

[cvinh]

From a technical perspective, LGTM.

Would you be open to adding a test covering the change you introduced to the "standard" feature? Before this PR, my understanding from the code is that every newly created subscription automatically started. Now, with your setting, that won't happen by default.

I think adding a test would be a good safety measure—let's see how it goes. You can ping me then.

Also, would you be so kind to review my #1410 in return?

tests added

[cvinh]

I don't understand why tests fail

[rrebollo]

Code Review. LGTM!

[rrebollo]

@cvinh did you rebase? The tests might pass then.

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.