[18.0][FIX] commission_oca,account_commission_oca: Restore grouped settlement report - #686
Open
carlosdauden wants to merge 1 commit into
Open
carlosdauden wants to merge 1 commit into
carlosdauden wants to merge 1 commit into
Conversation
Contributor
|
Hi @pedrobaeza, |
OCA-git-bot
added
series:18.0
mod:commission_oca
carlos-lopez-tecnativa
suggested changes
Sep 9, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
The report was added in this PR for V17: #648, and it was merged in November 2025. However, the migration to V18 was performed in #610 and merged in April 2025. Therefore, when the module was migrated, the report did not exist yet. For this reason, there is no evidence in the migration PR that the report was deleted.
The forward port was missing once the PR was merged. Thanks for forward-porting this!
carlosdauden
force-pushed
the
18.0-FIX-commission_grouped_settlement_report
branch
from
September 9, 2026 14:46
43e2cc3 to
a6cbfb8
Compare
Contributor
Author
|
Changes done |
carlos-lopez-tecnativa
approved these changes
Sep 9, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
There was a problem hiding this comment.
LGTM, please FW-port this to V19. Thanks!
Contributor
Author
|
FW-port done: #687 |
rrebollo
approved these changes
Sep 14, 2026
rrebollo
left a comment
rrebollo
left a comment
There was a problem hiding this comment.
Code Review: Great work! The code looks good to me (LGTM). Thank you for your contribution! I've provided a few suggestions for your consideration—feel free to address them as you see fit.
Hey, would you be so kind as to review my #676 in return?
…nt report The "Grouped Settlement" printable report (a summarized PDF grouping a commission.settlement's lines by day+commission, distinct from the existing itemized settlement report) was missing in 18.0. It was added to 17.0 by OCA#648 (merged November 2025), but the 18.0 migration PR OCA#610 had already been merged in April 2025 - before the report existed - so this is a forward-port gap, not something the migration dropped. Restored verbatim from 17.0 (only renaming xmlid references for the module rename, commission -> commission_oca): - commission_oca: CommissionSettlement.grouped_report_lines() (groups settlement lines by day+commission via read_group), the grouped_report_settlement_document/grouped_report_settlement QWeb templates, and the action_grouped_report_settlement report action (bound to commission.settlement, appears in its Print menu). - account_commission_oca: the grouped_report_lines() override for settlement_type == "sale_invoice" (groups by date+invoice instead, with invoice/partner/subtotal columns), and the matching XPath view inheritance adding those columns to the base template. Both ported tests included (test_grouped_report_lines, test_grouped_report_lines_sale_invoice), plus verified both reports actually render to PDF without error, not just pass their unit tests.
carlosdauden
force-pushed
the
18.0-FIX-commission_grouped_settlement_report
branch
from
September 16, 2026 11:29
a6cbfb8 to
f8a40cc
Compare
Contributor
Author
|
Changes done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Grouped Settlement" printable report (a summarized PDF grouping a commission.settlement's lines by day+commission, distinct from the existing itemized settlement report) existed through 17.0 - method, QWeb templates, report action, and its own test - and was entirely dropped in the 18.0 migration, no trace anywhere. Real money/ settlement-facing functionality, silently gone.
Restored verbatim from 17.0 (only renaming xmlid references for the module rename, commission -> commission_oca):
Both ported tests included (test_grouped_report_lines, test_grouped_report_lines_sale_invoice), plus verified both reports actually render to PDF without error, not just pass their unit tests.
@Tecnativa
ping @sergio-teruel @CarlosRoca13 @carlos-lopez-tecnativa