Repository navigation
Fix deck update - #483
Merged
Merged
Fix deck update#483
Conversation
Merged
migueldlr
force-pushed
the
migueldlr/fix-deck-update
branch
from
October 12, 2026 21:55
b73460a to
7013c25
Compare
plural
approved these changes
Oct 12, 2026
plural
left a comment
plural
left a comment
Contributor
There was a problem hiding this comment.
nice, thanks for fixing this!!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, every
PATCH /api/v3/private/decks/:idcauses a 500. This change callsdeck.deck_cards.create!instead ofcard_slots.create!(card_slotsis a Hash, not an association), and only clears and rebuilds cards whencard_slotsis sent, so a notes-only update no longer wipes the deck.