Skip to content

build: keep the build-id when linking with debug info #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amaanq merged 2 commits into from
Oct 30, 2026
Merged

build: keep the build-id when linking with debug info #115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0552f7d
build: keep the build-id when linking with debug info
amaanq Oct 30, 2026
eba3df0
cargo: bump to 1.2.3
amaanq Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,11 @@ edition = "2024"
license = "GPL-3.0"
repository = "https://github.com/notashelf/microfetch"
rust-version = "1.95.0"
version = "1.2.2"
version = "1.2.3"

[workspace.dependencies]
microfetch-asm = { path = "./crates/asm", version = "1.2.2" }
microfetch-lib = { path = "./crates/lib", version = "1.2.2" }
microfetch-asm = { path = "./crates/asm", version = "1.2.3" }
microfetch-lib = { path = "./crates/lib", version = "1.2.3" }

criterion = { default-features = false, features = [ "cargo_bench_support" ], version = "0.8.2" }

Expand Down
8 changes: 5 additions & 3 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,15 @@ fn main() -> io::Result<()> {
// Remove unreferenced input sections
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,--gc-sections");
// Strip all symbol table entries
if env::var("DEBUG").as_deref() != Ok("true") {
let debug = env::var("DEBUG").as_deref() == Ok("true");
if !debug {
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,--strip-all");
}
// Omit the .note.gnu.build-id section, which split debug info is found by
let build_id = if debug { "sha1" } else { "none" };
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,--build-id={build_id}");
// Nothing unwinds with panic=abort, so skip the unwinder's lookup table
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,--no-eh-frame-hdr");
// Omit the .note.gnu.build-id section
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,--build-id=none");
// Disable RELRO (removes relro_padding)
println!("cargo:rustc-link-arg-bin=microfetch=-Wl,-z,norelro");

Expand Down
Loading