Skip to content

docs(contributing): document PR review iteration and comment resolution workflow - #190

Merged
BharathASL merged 2 commits into
mainfrom
docs/pr-review-iteration-guidelines
Sep 1, 2026
Merged

docs(contributing): document PR review iteration and comment resolution workflow#190
BharathASL merged 2 commits into
mainfrom
docs/pr-review-iteration-guidelines

Conversation

@BharathASL

Copy link
Copy Markdown
Contributor

Description

Ticket: None (Standalone guidelines update)

This PR formally documents the PR Review & Iteration Workflow in CONTRIBUTING.md:

  • No Force-Pushing During Active Review: Prohibits amending/force-pushing on branches with active review feedback to preserve review history and range diffs.
  • Separate Fix Commits: Requires subsequent review fixes to be pushed as new, standalone Conventional Commits signed off with DCO (git commit -s).
  • Linking Commit SHAs: Requires responses to review comments and threads to cite the specific commit SHA(s) that introduced each fix.
  • Squashing at Merge: Clarifies that branch history is squashed/rebased at merge time.

Affected Assets

  • CONTRIBUTING.md

Type of Change

  • docs: Documentation improvement

Contributor Checklist

  • Commit message follows Conventional Commits format (docs(contributing): ...).
  • Every commit is signed off with the Developer Certificate of Origin (git commit -s).
  • Branch is rebased cleanly onto latest main with no merge commits.
  • Formatting complies with .editorconfig.

BharathASL and others added 2 commits August 31, 2026 07:51
…on workflow

- Define no force-push rule during active PR reviews

- Specify separate fix commits with DCO sign-off

- Require linking commit SHAs when resolving reviewer feedback

Signed-off-by: Bharath <bharathasl74185@gmail.com>

@ninja6-agent ninja6-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ninja6-agent Review: Keyframe #190

  • Type & Scope: Documentation update (docs/pr-review-iteration-guidelines)
  • Conformance: Fully conforms to CONTRIBUTING.md standards and DCO requirements
  • Standards Check: PASS (0 violations)
  • CI Matrix: PASS (Build and Test, dco, standards)

Documentation additions are clear, accurate, and ready for merge.

@BharathASL
BharathASL merged commit 1f5f870 into main Sep 1, 2026
4 checks passed
@BharathASL
BharathASL deleted the docs/pr-review-iteration-guidelines branch September 1, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant