Fix stale runtime version string and automate version bumps - #37
Merged
Conversation
rswalkden
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix stale runtime version string and automate version bumps
Summary
_N._VERSIONinsrc/lua_resty_netacea.luawas still hardcoded to1.6.0despite the rockspec having moved to1.6.2-0in an earlier release — sorequire("lua_resty_netacea")._VERSIONreported the wrong version at runtime. Bumped it to1.6.3in lockstep with a new rockspec (lua_resty_netacea-1.6.3-0.rockspec).check_rockspec_version.shto also assert that_N._VERSIONmatches the rockspec's release version, so this can't silently drift again — it previously only checked the rockspec filename against its ownversionfield and against existing git tags.bump_version.sh <new-version>to automate the release checklist: renames the rockspec, updates itsversionfield, updates_N._VERSION, and runscheck_rockspec_version.shto confirm everything agrees.CONTRIBUTING.md's "Updating the version number" section to point at the new script instead of the old manual 3-step checklist.Why
Manually keeping the rockspec version and the in-code version string in sync is easy to forget, and
check_rockspec_version.shhad no way to catch it — it verified the rockspec was internally consistent but never looked at the module source. This fixes today's instance of the bug and closes the gap so CI catches the next one.Test plan
./check_rockspec_version.shpasses against the new rockspec/version../bump_version.sh 1.6.4exercised manually (renamed rockspec, updated both version strings, ran the check successfully), then reverted back to1.6.3since that was just a dry run.build.yml) runscheck_rockspec_version.shas before — should still pass on this branch.