Fix and harden the LuaRocks publish pipeline - #36
Merged
Conversation
rswalkden
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix and harden the LuaRocks publish pipeline
Fixes the publish-luarocks workflow, which failed on first real use, and adds guardrails to stop bad rockspecs reaching master.
Changes
luarocksin the publish workflow — the OpenResty apt package doesn't ship it, only the Docker image builds one in image;lint/make/uploadall need it onPATH.dkjsonforluarocksitself —luarocks uploadneeds a JSON library available to its own Lua environment, separate from the project'slua-cjsonruntime dependency (which only lands in the throwaway test tree).check_rockspec_version.sh, wired into the PR/push build workflow, which fails the build if:version = "..."field disagree, orvX.Y.Zgit tag already exists (catches an unbumped version before merge, not after release).COPYinDockerfileandDockerfile.nginx_luato*.rockspecinstead of a hardcoded filename, so bumping the version no longer requires touching either Dockerfile. UpdatedCONTRIBUTING.mdto drop that now-unnecessary step.Testing
publish_to_luarocks.shsuccessfully lints, pins the source tag, and uploads to luarocks.org.check_rockspec_version.shcorrectly rejects an already-tagged version (tested againstv1.6.2, then cleaned up).