Repository navigation
Fix NU1004 restore failure by referencing .NET Framework reference assemblies explicitly - #520
Open
DominikPalo wants to merge 1 commit into
Open
DominikPalo wants to merge 1 commit into
DominikPalo wants to merge 1 commit into
Conversation
The .NET SDK adds this package implicitly only when the .NET Framework targeting pack is missing. The lock files were regenerated on such a machine, so restore in locked mode failed with NU1004 on the Windows CI runner where the targeting pack is installed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testsworkflow has been failing onmainsince thereleases/netoffice_v1.9.11merge (afc621391). Every project fails restore in locked mode with:Cause
The .NET SDK adds
Microsoft.NETFramework.ReferenceAssemblieson its own only when the .NET Framework targeting pack is not installed. Thepackages.lock.jsonfiles were regenerated on a machine without the net462 targeting pack, so they list the package. Thewindows-2025runner has the targeting pack, so the SDK doesn't add the package there. The lock files and the projects disagree, andRestoreLockedMode=truefails the build.Fix
Reference
Microsoft.NETFramework.ReferenceAssemblies1.0.3 explicitly (PrivateAssets="All") inSource/NetOffice.props. That way the dependency graph is the same on every machine. Every project with a lock file importsNetOffice.props, and the lock files already pin[1.0.3, ), so no lock file changes are needed.Notes for reviewers
🤖 Generated with Claude Code