Repository navigation
CSTACKEX-367: Remove LUN-map logical unit number dead code - #138
Open
sandeeplocharla wants to merge 1 commit into
Open
sandeeplocharla wants to merge 1 commit into
sandeeplocharla wants to merge 1 commit into
Conversation
sandeeplocharla
requested review from
piyush5netapp,
rajiv-jain-netapp and
suryag1201
as code owners
November 11, 2026 06:32
Since the managed iSCSI path became /<targetIQN>/<lunWwid> (PR #114), nothing consumes the LUN-map logical unit number. Stop fetching and returning it: - enableLogicalAccess/ensureLunMapped now return void; the follow-up lun-maps GET that only read the number is removed - getLogicalAccess returns boolean (mapping exists) - drop OntapStorageConstants.LOGICAL_UNIT_NUMBER and LUN-number logging in OntapPrimaryDatastoreDriver - update unit tests, asserting a new mapping needs one lookup and one create
sandeeplocharla
force-pushed
the
bugfix/CSTACKEX-367
branch
from
November 11, 2026 06:34
11be34b to
82b261f
Compare
🔴 Test Coverage Grade:
|
| Metric | Value |
|---|---|
| Line coverage | 25.82% |
| Branch coverage | 20.11% |
Grade Scale
| Grade | Line Coverage | Meaning |
|---|---|---|
| 🟢 A | ≥ 80% | Excellent - this code sleeps well at night 😴 |
| 🟡 B | 60-79% | Good - almost there, don't stop now 😉 |
| 🟠 C | 40-59% | Acceptable - your code is wearing a seatbelt, but no airbags 😬 |
| 🔴 D | 20-39% | Marginal - boldly shipping where no test has gone before 🖖 |
| ⛔ F | < 20% | Failing - tests? what tests? 🔥 |
Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the managed iSCSI path became // (PR #114), nothing consumes the LUN-map logical unit number. Stop fetching and returning it:
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?