Market data: Poloniex to Coingecko

[curupo]

No description provided.

[AnthonyLaw]

Great work! I’ve left a few comments on the PR. Please don’t forget to add tests as well. 🙏🏼

[curupo]

Thanks for the review.
I've addressed the points you raised.
What do you think?

[AnthonyLaw]

Great work!

[curupo]

Thanks for the review.
Testing was insufficient. I apologize.

[AnthonyLaw]

Thanks for the review. Testing was insufficient. I apologize.

No worries, it looks good now!
Great work 🙏🏼

[cryptoBeliever]

Hi @curupo, my only comment from testing is that I'd prefer the Price (Bitcoin) value to be shown in decimal notation instead of scientific notation.

At this moment it's:

But my preference is to present like this:

To change that in marketData.html, line 23 we can change (I think this is good enough):

<span><i class="fa fa-bitcoin"></i> {{$ctrl._DataStore.market.xem.highestBid | number:12}}</span>

[masaakisaitoh]

@cryptoBeliever, thank you for the review.

1. I have made the fix. I verified that it works and have pushed the changes.

[AnthonyLaw]

👍🏼
cc @cryptoBeliever

[cryptoBeliever]

Looks good 👍 Thank you!