Repository navigation
fix: reject invalid content after the root element - #916
Open
blueDaydreaming725 wants to merge 1 commit into
Open
blueDaydreaming725 wants to merge 1 commit into
blueDaydreaming725 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #899.
XML's epilog permits whitespace, comments, and processing instructions, but not character references, CDATA, DOCTYPE, or another root element. The validator's text-scanning loop handled references and markup before applying its existing
reachedRootcheck. Self-closing roots also never marked that state.This change rejects references and non-comment
<!...>markup after the root, records when a self-closing root completes, and applies the existing multiple-root error to a following self-closing element. Valid epilog content and the same constructs inside the root remain supported.Validation
Node 24.22.1 on macOS:
npx jasmine spec/validator_spec.js— 68 specs, 0 failures.npm test— 343 specs, 0 failures, 2 existing pending specs.npm run test-typesandnpm run bundlepass.npm run lintcannot start because its script references the absentbenchmark/**/*.jspath. A broader direct ESLint invocation also reports existing errors; neither is claimed as a passing lint check.