feat: commonLoggerCreate accepts a context function, read on every call - #162
Merged
Merged
Conversation
For loggers on objects whose context is filled in after creation, e.g a RequestContext that resolves its user later. `child` merges either form. Claude-Session: https://claude.ai/code/session_01JuGyKbJyWXdXBeNS7VdnU1
fiddur
marked this pull request as ready for review
September 24, 2026 15:07
… object Normalise the context into one getter at creation; child merges the getters. Claude-Session: https://claude.ai/code/session_01JuGyKbJyWXdXBeNS7VdnU1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commonLoggerCreate(sink, context)andchild(context)now also take() => AnyObject. A function is called on every log call; a plain object is still copied once.childmerges either form, child keys win.Motivation: loggers on objects whose context is filled in after creation, e.g.
RequestContext