Repository navigation
docs(mobile/4): note inline handlers only work in Jump - #557
Open
sonalidudhia wants to merge 1 commit into
Open
sonalidudhia wants to merge 1 commit into
sonalidudhia wants to merge 1 commit into
Conversation
Inline handlers like @press="$showSheet = false" work in Jump previews but mobile-air doesn't support them, so copied examples leave modals and sheets that won't close. Add a note under the first modal and bottom-sheet example showing the method-based alternative. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline handlers like
@press="$showSheet = false"work in Jump previews but not in a real app — mobile-air (latestmain, 11 Oct) doesn't support them. Anyone copying the modal / bottom-sheet examples ends up with a modal or sheet that won't close.Examples left as-is (they work in Jump). Added a short note under the first example on each page showing the method-based alternative:
mobile/4/edge-components/modal.mdmobile/4/edge-components/bottom-sheet.mdIf mobile-air later gains support for inline handlers, these notes can be removed.
Tests
modal_and_bottom_sheet_pages_note_that_inline_handlers_only_work_in_jumptoDocumentationRenderingTest.