Add Bifrost & Desktop sidebar ads, cross-platform docs rotation#421
Merged
Conversation
- Add a Bifrost cloud-platform ad and a NativePHP Desktop ad to the sidebar ad rotation - Rotate the Desktop ad on Mobile docs and the Mobile ad on Desktop docs (never a platform's own ad) - Remove the "Early Bird Pricing" label from the Masterclass ad - Set an explicit white page background in light mode on the main site layout - Add feature tests for the rotation, cross-platform docs wiring, and Early Bird removal Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the sidebar ad rotation with two new ads and cleans up a couple of related UI details.
Ads
BIFROSTwordmark, "Ship it!" CTA, Fathom click tracking). Added to the sidebar/blog/article rotations./docs/desktop).Cross-platform rotation on the docs
The two platform ads now cross-promote each other, and never advertise the platform you're already reading:
(Blog/article sidebars are platform-agnostic and rotate through both.)
Other tweaks
layout.blade.phppreviously only set a dark-mode background, leaving light mode at the browser default).Testing
tests/Feature/AdRotationTest.php(7 tests) covering: Bifrost & Desktop ads in the rotation, the desktop-ad-on-mobile-docs / mobile-ad-on-desktop-docs wiring (hitting the real/docs/desktopand/docs/mobileroutes), ad exclusion, and the Early Bird removal.vendor/bin/pintclean; assets rebuilt withnpm run build.🤖 Generated with Claude Code